mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Stephen Boyd <stephen.boyd@linaro.org>,
	robdclark@gmail.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency
Date: Mon, 24 Jul 2017 10:05:45 +0200	[thread overview]
Message-ID: <1500883545.2391.31.camel@pengutronix.de> (raw)
In-Reply-To: <20170721205625.3375683-1-arnd@arndb.de>

Hi Arnd,

On Fri, 2017-07-21 at 22:56 +0200, Arnd Bergmann wrote:
> The new PRE/PRG driver code causes a link failure when DRM is disabled:
> 
> drivers/gpu/ipu-v3/ipu-pre.o: In function `ipu_pre_configure':
> ipu-pre.c:(.text.ipu_pre_configure+0x18): undefined reference to `drm_format_info'
> drivers/gpu/ipu-v3/ipu-prg.o: In function `ipu_prg_format_supported':
> ipu-prg.c:(.text.ipu_prg_format_supported+0x8): undefined reference to `drm_format_info'
> 
> Adding a Kconfig dependency on DRM means we don't run into this problem
> any more. This might not be the best solution though, as the ipu seems
> to have been intentionally kept separate from DRM in the past.
> 
> Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket")
> Link: https://patchwork.kernel.org/patch/9636665/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Originally sent on March 21, but got no reply for it. Resending unchanged
> as it is still needed in v4.13-rc1

thank you for fix and for the resend. I have the original patch in my
inbox, I'm sorry I overlooked it.

I would still like to keep the ipu-v3 driver buildable without DRM
enabled. For now, I have applied your patch as is.

regards
Philipp

  reply	other threads:[~2017-07-24  8:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 20:56 Arnd Bergmann
2017-07-24  8:05 ` Philipp Zabel [this message]
2017-07-25  7:33   ` Arnd Bergmann
2017-07-25  8:03     ` Philipp Zabel
2017-07-25 11:35       ` Arnd Bergmann
2017-07-25 11:52         ` Philipp Zabel
2017-07-25 11:58           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500883545.2391.31.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=arnd@arndb.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=stephen.boyd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®