* [PATCH 22/29] scsi: pmcraid: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
@ 2017-07-30 8:43 ` Arvind Yadav
2017-07-30 8:43 ` [PATCH 23/29] scsi: fnic: " Arvind Yadav
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:43 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/pmcraid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 1cc814f..1a9e153 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -126,7 +126,7 @@ static struct pmcraid_chip_details pmcraid_chip_cfg[] = {
/*
* PCI device ids supported by pmcraid driver
*/
-static struct pci_device_id pmcraid_pci_table[] = {
+static const struct pci_device_id pmcraid_pci_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_PMC, PCI_DEVICE_ID_PMC_MAXRAID),
0, 0, (kernel_ulong_t)&pmcraid_chip_cfg[0]
},
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 23/29] scsi: fnic: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
2017-07-30 8:43 ` [PATCH 22/29] scsi: pmcraid: " Arvind Yadav
@ 2017-07-30 8:43 ` Arvind Yadav
2017-07-30 8:43 ` [PATCH 24/29] scsi: stex: " Arvind Yadav
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:43 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/fnic/fnic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index aacadbf..b3ab344 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -53,7 +53,7 @@ LIST_HEAD(fnic_list);
DEFINE_SPINLOCK(fnic_list_lock);
/* Supported devices by fnic module */
-static struct pci_device_id fnic_id_table[] = {
+static const struct pci_device_id fnic_id_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_CISCO_FNIC) },
{ 0, }
};
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 24/29] scsi: stex: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
2017-07-30 8:43 ` [PATCH 22/29] scsi: pmcraid: " Arvind Yadav
2017-07-30 8:43 ` [PATCH 23/29] scsi: fnic: " Arvind Yadav
@ 2017-07-30 8:43 ` Arvind Yadav
2017-07-30 8:43 ` [PATCH 25/29] scsi: megaraid: " Arvind Yadav
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:43 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/stex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 9b20643..21d0495 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -1491,7 +1491,7 @@ static struct scsi_host_template driver_template = {
.this_id = -1,
};
-static struct pci_device_id stex_pci_tbl[] = {
+static const struct pci_device_id stex_pci_tbl[] = {
/* st_shasta */
{ 0x105a, 0x8350, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
st_shasta }, /* SuperTrak EX8350/8300/16350/16300 */
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 25/29] scsi: megaraid: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
` (2 preceding siblings ...)
2017-07-30 8:43 ` [PATCH 24/29] scsi: stex: " Arvind Yadav
@ 2017-07-30 8:43 ` Arvind Yadav
2017-07-30 8:43 ` [PATCH 26/29] scsi: a100u2w: " Arvind Yadav
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:43 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 316c3df..ed2acda 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -124,7 +124,7 @@ static int megasas_get_target_prop(struct megasas_instance *instance,
/*
* PCI ID table for all supported controllers
*/
-static struct pci_device_id megasas_pci_table[] = {
+static const struct pci_device_id megasas_pci_table[] = {
{PCI_DEVICE(PCI_VENDOR_ID_LSI_LOGIC, PCI_DEVICE_ID_LSI_SAS1064R)},
/* xscale IOP */
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 26/29] scsi: a100u2w: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
` (3 preceding siblings ...)
2017-07-30 8:43 ` [PATCH 25/29] scsi: megaraid: " Arvind Yadav
@ 2017-07-30 8:43 ` Arvind Yadav
2017-07-30 8:43 ` [PATCH 27/29] scsi: advansys: " Arvind Yadav
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:43 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/a100u2w.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
index 8086bd0..80c39fd 100644
--- a/drivers/scsi/a100u2w.c
+++ b/drivers/scsi/a100u2w.c
@@ -1209,7 +1209,7 @@ static void inia100_remove_one(struct pci_dev *pdev)
scsi_host_put(shost);
}
-static struct pci_device_id inia100_pci_tbl[] = {
+static const struct pci_device_id inia100_pci_tbl[] = {
{PCI_VENDOR_ID_INIT, 0x1060, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{0,}
};
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 27/29] scsi: advansys: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
` (4 preceding siblings ...)
2017-07-30 8:43 ` [PATCH 26/29] scsi: a100u2w: " Arvind Yadav
@ 2017-07-30 8:43 ` Arvind Yadav
2017-07-30 8:43 ` [PATCH 28/29] scsi: atp870u: " Arvind Yadav
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:43 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/advansys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 24e57e7..350070f 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -11714,7 +11714,7 @@ static struct eisa_driver advansys_eisa_driver = {
};
/* PCI Devices supported by this driver */
-static struct pci_device_id advansys_pci_tbl[] = {
+static const struct pci_device_id advansys_pci_tbl[] = {
{PCI_VENDOR_ID_ASP, PCI_DEVICE_ID_ASP_1200A,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{PCI_VENDOR_ID_ASP, PCI_DEVICE_ID_ASP_ABP940,
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 28/29] scsi: atp870u: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
` (5 preceding siblings ...)
2017-07-30 8:43 ` [PATCH 27/29] scsi: advansys: " Arvind Yadav
@ 2017-07-30 8:43 ` Arvind Yadav
2017-07-30 8:43 ` [PATCH 29/29] scsi: 3w-xxxx: " Arvind Yadav
2017-08-07 1:37 ` [PATCH 21/29] scsi: nsp32: " Masanori Goto
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:43 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/atp870u.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c
index 8b52a9d..70f1bc4 100644
--- a/drivers/scsi/atp870u.c
+++ b/drivers/scsi/atp870u.c
@@ -1685,7 +1685,7 @@ static struct scsi_host_template atp870u_template = {
.max_sectors = ATP870U_MAX_SECTORS,
};
-static struct pci_device_id atp870u_id_table[] = {
+static const struct pci_device_id atp870u_id_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_ARTOP, ATP885_DEVID) },
{ PCI_DEVICE(PCI_VENDOR_ID_ARTOP, ATP880_DEVID1) },
{ PCI_DEVICE(PCI_VENDOR_ID_ARTOP, ATP880_DEVID2) },
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 29/29] scsi: 3w-xxxx: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
` (6 preceding siblings ...)
2017-07-30 8:43 ` [PATCH 28/29] scsi: atp870u: " Arvind Yadav
@ 2017-07-30 8:43 ` Arvind Yadav
2017-08-07 1:37 ` [PATCH 21/29] scsi: nsp32: " Masanori Goto
8 siblings, 0 replies; 10+ messages in thread
From: Arvind Yadav @ 2017-07-30 8:43 UTC (permalink / raw)
To: martin.petersen, jejb, mdr, hare, aacraid, matthew, fthain,
schmitzmic, kashyap.desai, sumit.saxena, gotom, mrochs,
QLogic-Storage-Upstream, jinpu.wang
Cc: linux-scsi, linux-kernel
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/3w-xxxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
index 33261b6..e0b079d 100644
--- a/drivers/scsi/3w-xxxx.c
+++ b/drivers/scsi/3w-xxxx.c
@@ -2384,7 +2384,7 @@ static void tw_remove(struct pci_dev *pdev)
} /* End tw_remove() */
/* PCI Devices supported by this driver */
-static struct pci_device_id tw_pci_tbl[] = {
+static const struct pci_device_id tw_pci_tbl[] = {
{ PCI_VENDOR_ID_3WARE, PCI_DEVICE_ID_3WARE_1000,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ PCI_VENDOR_ID_3WARE, PCI_DEVICE_ID_3WARE_7000,
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 21/29] scsi: nsp32: constify pci_device_id.
2017-07-30 8:43 [PATCH 21/29] scsi: nsp32: constify pci_device_id Arvind Yadav
` (7 preceding siblings ...)
2017-07-30 8:43 ` [PATCH 29/29] scsi: 3w-xxxx: " Arvind Yadav
@ 2017-08-07 1:37 ` Masanori Goto
8 siblings, 0 replies; 10+ messages in thread
From: Masanori Goto @ 2017-08-07 1:37 UTC (permalink / raw)
To: Arvind Yadav
Cc: martin.petersen, jejb, Michael Reed, hare, aacraid,
Matthew Wilcox, fthain, schmitzmic, kashyap.desai, sumit.saxena,
mrochs, QLogic-Storage-Upstream, jinpu.wang, linux-scsi,
linux-kernel
2017-07-30 17:43 GMT+09:00 Arvind Yadav <arvind.yadav.cs@gmail.com>:
>
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thank you! (resending it twice due to an error)
Acked-by: Masanori Goto <gotom@debian.or.jp>
> ---
> drivers/scsi/nsp32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
> index 53c8477..1430b3c 100644
> --- a/drivers/scsi/nsp32.c
> +++ b/drivers/scsi/nsp32.c
> @@ -76,7 +76,7 @@ static const char *nsp32_release_version = "1.2";
> /****************************************************************************
> * Supported hardware
> */
> -static struct pci_device_id nsp32_pci_table[] = {
> +static const struct pci_device_id nsp32_pci_table[] = {
> {
> .vendor = PCI_VENDOR_ID_IODATA,
> .device = PCI_DEVICE_ID_NINJASCSI_32BI_CBSC_II,
> --
> 2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread