* crypto: ccp: use dma_mapping_error to check map error
@ 2017-08-08 13:42 Pan Bian
2017-08-08 15:26 ` Gary R Hook
2017-08-17 9:00 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Pan Bian @ 2017-08-08 13:42 UTC (permalink / raw)
To: Tom Lendacky, Gary Hook, Herbert Xu, David S. Miller
Cc: linux-crypto, linux-kernel, Pan Bian
The return value of dma_map_single() should be checked by
dma_mapping_error(). However, in function ccp_init_dm_workarea(), its
return value is checked against NULL, which could result in failures.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/crypto/ccp/ccp-ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index c0dfdac..ca83d19 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -168,7 +168,7 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa,
wa->dma.address = dma_map_single(wa->dev, wa->address, len,
dir);
- if (!wa->dma.address)
+ if (dma_mapping_error(wa->dev, wa->dma.address))
return -ENOMEM;
wa->dma.length = len;
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: crypto: ccp: use dma_mapping_error to check map error
2017-08-08 13:42 crypto: ccp: use dma_mapping_error to check map error Pan Bian
@ 2017-08-08 15:26 ` Gary R Hook
2017-08-17 9:00 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Gary R Hook @ 2017-08-08 15:26 UTC (permalink / raw)
To: Pan Bian, Lendacky, Thomas, Herbert Xu, David S. Miller
Cc: linux-crypto, linux-kernel
On 08/08/2017 08:42 AM, Pan Bian wrote:
> The return value of dma_map_single() should be checked by
> dma_mapping_error(). However, in function ccp_init_dm_workarea(), its
> return value is checked against NULL, which could result in failures.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Gary R Hook <gary.hook@amd.com>
> ---
> drivers/crypto/ccp/ccp-ops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index c0dfdac..ca83d19 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -168,7 +168,7 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa,
>
> wa->dma.address = dma_map_single(wa->dev, wa->address, len,
> dir);
> - if (!wa->dma.address)
> + if (dma_mapping_error(wa->dev, wa->dma.address))
> return -ENOMEM;
>
> wa->dma.length = len;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: crypto: ccp: use dma_mapping_error to check map error
2017-08-08 13:42 crypto: ccp: use dma_mapping_error to check map error Pan Bian
2017-08-08 15:26 ` Gary R Hook
@ 2017-08-17 9:00 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2017-08-17 9:00 UTC (permalink / raw)
To: Pan Bian
Cc: Tom Lendacky, Gary Hook, David S. Miller, linux-crypto, linux-kernel
On Tue, Aug 08, 2017 at 09:42:47PM +0800, Pan Bian wrote:
> The return value of dma_map_single() should be checked by
> dma_mapping_error(). However, in function ccp_init_dm_workarea(), its
> return value is checked against NULL, which could result in failures.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-17 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 13:42 crypto: ccp: use dma_mapping_error to check map error Pan Bian
2017-08-08 15:26 ` Gary R Hook
2017-08-17 9:00 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®