* [PATCH] tracing: Fix clear of RECORDED_TGID flag when disabling trace event
@ 2017-09-05 5:36 Chunyu Hu
2017-09-05 15:59 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Chunyu Hu @ 2017-09-05 5:36 UTC (permalink / raw)
To: rostedt; +Cc: mingo, linux-kernel, chuhu
When disabling one trace event, the RECORDED_TGID flag in the event
file is not correctly cleared. It's clearing RECORDED_CMD flag when
it should clear RECORDED_TGID flag. Fix d914ba37("tracing: Add support
for recording tgid of tasks")
Signed-off-by: Chunyu Hu <chuhu@redhat.com>
---
kernel/trace/trace_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index c93540c..8746839 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -406,7 +406,7 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file,
if (file->flags & EVENT_FILE_FL_RECORDED_TGID) {
tracing_stop_tgid_record();
- clear_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags);
+ clear_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags);
}
call->class->reg(call, TRACE_REG_UNREGISTER, file);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] tracing: Fix clear of RECORDED_TGID flag when disabling trace event
2017-09-05 5:36 [PATCH] tracing: Fix clear of RECORDED_TGID flag when disabling trace event Chunyu Hu
@ 2017-09-05 15:59 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2017-09-05 15:59 UTC (permalink / raw)
To: Chunyu Hu; +Cc: mingo, linux-kernel, Joel Fernandes
On Tue, 5 Sep 2017 13:36:46 +0800
Chunyu Hu <chuhu@redhat.com> wrote:
> When disabling one trace event, the RECORDED_TGID flag in the event
> file is not correctly cleared. It's clearing RECORDED_CMD flag when
> it should clear RECORDED_TGID flag. Fix d914ba37("tracing: Add support
> for recording tgid of tasks")
>
> Signed-off-by: Chunyu Hu <chuhu@redhat.com>
Thanks! Applied.
-- Steve
> ---
> kernel/trace/trace_events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index c93540c..8746839 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -406,7 +406,7 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file,
>
> if (file->flags & EVENT_FILE_FL_RECORDED_TGID) {
> tracing_stop_tgid_record();
> - clear_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags);
> + clear_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags);
> }
>
> call->class->reg(call, TRACE_REG_UNREGISTER, file);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-05 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-05 5:36 [PATCH] tracing: Fix clear of RECORDED_TGID flag when disabling trace event Chunyu Hu
2017-09-05 15:59 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®