From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: labbott@redhat.com, sumit.semwal@linaro.org,
gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com, broonie@kernel.org,
dan.carpenter@oracle.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: [PATCH v3 0/2] staging: ion: get one device per heap
Date: Wed, 20 Sep 2017 10:45:03 +0200 [thread overview]
Message-ID: <1505897105-23721-1-git-send-email-benjamin.gaignard@linaro.org> (raw)
version 3:
- change ion_device_add_heap prototype to return a possible error
version 2:
- simplify ioctl check like propose by Dan
- make sure that we don't register more than ION_DEV_MAX heaps
Until now all ion heaps are addressing using the same device "/dev/ion".
This way of working doesn't allow to give access rights (for example with
SElinux rules) per heap.
This series propose to have one device "/dev/ionX" per heap.
Query heaps informations will be possible on each device node but allocation
request will only be possible if heap_mask_id match with device minor number.
That really change ion ABI because:
- device name change
- allocation must be done on the correct device/heap.
- device major number will not be the same and that could impact init scripts.
Even if splitting ion device in multiple node was one of the item of the
de-staging TODO list this must be agreed by a larger audience because it is
(again) an ion ABI bing bang. Hopefully that could be discussed at next XDC
to get a decission on this particular point.
Benjamin Gaignard (2):
staging: ion: simplify ioctl args checking function
staging: ion: create one device entry per heap
drivers/staging/android/TODO | 1 -
drivers/staging/android/ion/ion-ioctl.c | 20 +++++++++++++-------
drivers/staging/android/ion/ion.c | 27 ++++++++++++++++++++-------
drivers/staging/android/ion/ion.h | 12 ++++++++----
4 files changed, 41 insertions(+), 19 deletions(-)
--
2.7.4
next reply other threads:[~2017-09-20 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:45 Benjamin Gaignard [this message]
2017-09-20 8:45 ` [PATCH v3 1/2] staging: ion: simplify ioctl args checking function Benjamin Gaignard
2017-09-20 8:45 ` [PATCH v3 2/2] staging: ion: create one device entry per heap Benjamin Gaignard
2017-09-25 18:26 ` Laura Abbott
2017-09-26 5:09 ` Daniel Vetter
2017-09-26 6:56 ` Greg KH
2017-09-26 17:52 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505897105-23721-1-git-send-email-benjamin.gaignard@linaro.org \
--to=benjamin.gaignard@linaro.org \
--cc=arve@android.com \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®