From: Laura Abbott <labbott@redhat.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
sumit.semwal@linaro.org, gregkh@linuxfoundation.org,
arve@android.com, riandrews@android.com, broonie@kernel.org,
dan.carpenter@oracle.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/2] staging: ion: create one device entry per heap
Date: Mon, 25 Sep 2017 11:26:27 -0700 [thread overview]
Message-ID: <3dbd167f-c381-8451-5861-3788634885b7@redhat.com> (raw)
In-Reply-To: <1505897105-23721-3-git-send-email-benjamin.gaignard@linaro.org>
On 09/20/2017 01:45 AM, Benjamin Gaignard wrote:
> Instead a getting one common device "/dev/ion" for
> all the heaps this patch allow to create one device
> entry ("/dev/ionX") per heap.
> Getting an entry per heap could allow to set security rules
> per heap and global ones for all heaps.
>
> Allocation requests will be only allowed if the mask_id
> match with device minor.
> Query request could be done on any of the devices.
> Deivce node major will also change and that may impact init scripts.
>
We should start Cc linux-api for future changes since we're going
to have more than just /dev/ion.
Thinking about this some more, I think we need to allow backwards
compatibility. It's just not feasible to keep throwing workarounds
into userspace if we can avoid it. I'd propose keeping the old /dev/ion
misc interface available under a Kconfig and then creating the new
split heaps in parallel.
On a somewhat related note, there was some interest in possibly
having a sysfs interface for Ion long term. I don't think this
needs to happen right now but I'd like whatever we do to not
make adding that harder.
Thanks,
Laura
next prev parent reply other threads:[~2017-09-25 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:45 [PATCH v3 0/2] staging: ion: get one device " Benjamin Gaignard
2017-09-20 8:45 ` [PATCH v3 1/2] staging: ion: simplify ioctl args checking function Benjamin Gaignard
2017-09-20 8:45 ` [PATCH v3 2/2] staging: ion: create one device entry per heap Benjamin Gaignard
2017-09-25 18:26 ` Laura Abbott [this message]
2017-09-26 5:09 ` Daniel Vetter
2017-09-26 6:56 ` Greg KH
2017-09-26 17:52 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbd167f-c381-8451-5861-3788634885b7@redhat.com \
--to=labbott@redhat.com \
--cc=arve@android.com \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®