* [PATCH] staging:rtl8188eu:hal Fix wrong comparison to False
@ 2017-09-21 5:39 Janani Sankara Babu
2017-09-21 7:09 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Janani Sankara Babu @ 2017-09-21 5:39 UTC (permalink / raw)
To: gregkh; +Cc: insafonov, goudapatilk, devel, linux-kernel, Janani Sankara Babu
This patch solves the warning "Using comparison to false is error prone"
Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
drivers/staging/rtl8188eu/hal/odm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c
index ec8aae7..001d626 100644
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -382,7 +382,7 @@ void odm_DIG(struct odm_dm_struct *pDM_Odm)
}
/* add by Neil Chen to avoid PSD is processing */
- if (pDM_Odm->bDMInitialGainEnable == false) {
+ if (!pDM_Odm->bDMInitialGainEnable) {
ODM_RT_TRACE(pDM_Odm, ODM_COMP_DIG, ODM_DBG_LOUD, ("odm_DIG() Return: PSD is Processing\n"));
return;
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging:rtl8188eu:hal Fix wrong comparison to False
2017-09-21 5:39 [PATCH] staging:rtl8188eu:hal Fix wrong comparison to False Janani Sankara Babu
@ 2017-09-21 7:09 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-09-21 7:09 UTC (permalink / raw)
To: Janani Sankara Babu; +Cc: gregkh, devel, goudapatilk, insafonov, linux-kernel
On Thu, Sep 21, 2017 at 11:09:55AM +0530, Janani Sankara Babu wrote:
> This patch solves the warning "Using comparison to false is error prone"
Out of curiosity, which tool complains about that?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-21 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-21 5:39 [PATCH] staging:rtl8188eu:hal Fix wrong comparison to False Janani Sankara Babu
2017-09-21 7:09 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®