* [PATCH] staging:vme Fix use BIT macro
@ 2017-09-21 5:52 Janani Sankara Babu
2017-09-21 11:49 ` Martyn Welch
0 siblings, 1 reply; 2+ messages in thread
From: Janani Sankara Babu @ 2017-09-21 5:52 UTC (permalink / raw)
To: gregkh
Cc: martyn, manohar.vanga, antonl1911, rjpdasilva, devel,
linux-kernel, Janani Sankara Babu
This patch is created to solve the following warning shown by the checkpatch
script Warning: Replace all occurences of (1<<x) by BIT(x)
Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
drivers/staging/vme/devices/vme_pio2.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_pio2.h b/drivers/staging/vme/devices/vme_pio2.h
index ac4a4ba..e9c3cf6 100644
--- a/drivers/staging/vme/devices/vme_pio2.h
+++ b/drivers/staging/vme/devices/vme_pio2.h
@@ -179,7 +179,7 @@
PIO2_REGS_CTRL_WRD1 };
#define PIO2_CNTR_SC_DEV0 0
-#define PIO2_CNTR_SC_DEV1 (1 << 6)
+#define PIO2_CNTR_SC_DEV1 BIT(6)
#define PIO2_CNTR_SC_DEV2 (2 << 6)
#define PIO2_CNTR_SC_RDBACK (3 << 6)
@@ -188,12 +188,12 @@
PIO2_CNTR_SC_DEV1, PIO2_CNTR_SC_DEV2 };
#define PIO2_CNTR_RW_LATCH 0
-#define PIO2_CNTR_RW_LSB (1 << 4)
+#define PIO2_CNTR_RW_LSB BIT(4)
#define PIO2_CNTR_RW_MSB (2 << 4)
#define PIO2_CNTR_RW_BOTH (3 << 4)
#define PIO2_CNTR_MODE0 0
-#define PIO2_CNTR_MODE1 (1 << 1)
+#define PIO2_CNTR_MODE1 BIT(1)
#define PIO2_CNTR_MODE2 (2 << 1)
#define PIO2_CNTR_MODE3 (3 << 1)
#define PIO2_CNTR_MODE4 (4 << 1)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging:vme Fix use BIT macro
2017-09-21 5:52 [PATCH] staging:vme Fix use BIT macro Janani Sankara Babu
@ 2017-09-21 11:49 ` Martyn Welch
0 siblings, 0 replies; 2+ messages in thread
From: Martyn Welch @ 2017-09-21 11:49 UTC (permalink / raw)
To: Janani Sankara Babu
Cc: Greg KH, Manohar Vanga, antonl1911, Ricardo Silva, devel, LKML
On 21 September 2017 at 06:52, Janani Sankara Babu <jananis37@gmail.com> wrote:
> This patch is created to solve the following warning shown by the checkpatch
> script Warning: Replace all occurences of (1<<x) by BIT(x)
>
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---
> drivers/staging/vme/devices/vme_pio2.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_pio2.h b/drivers/staging/vme/devices/vme_pio2.h
> index ac4a4ba..e9c3cf6 100644
> --- a/drivers/staging/vme/devices/vme_pio2.h
> +++ b/drivers/staging/vme/devices/vme_pio2.h
> @@ -179,7 +179,7 @@
> PIO2_REGS_CTRL_WRD1 };
>
> #define PIO2_CNTR_SC_DEV0 0
> -#define PIO2_CNTR_SC_DEV1 (1 << 6)
> +#define PIO2_CNTR_SC_DEV1 BIT(6)
Sorry, these changes just don't make sense given the defines below.
> #define PIO2_CNTR_SC_DEV2 (2 << 6)
> #define PIO2_CNTR_SC_RDBACK (3 << 6)
>
> @@ -188,12 +188,12 @@
> PIO2_CNTR_SC_DEV1, PIO2_CNTR_SC_DEV2 };
>
> #define PIO2_CNTR_RW_LATCH 0
> -#define PIO2_CNTR_RW_LSB (1 << 4)
> +#define PIO2_CNTR_RW_LSB BIT(4)
> #define PIO2_CNTR_RW_MSB (2 << 4)
> #define PIO2_CNTR_RW_BOTH (3 << 4)
>
> #define PIO2_CNTR_MODE0 0
> -#define PIO2_CNTR_MODE1 (1 << 1)
> +#define PIO2_CNTR_MODE1 BIT(1)
> #define PIO2_CNTR_MODE2 (2 << 1)
> #define PIO2_CNTR_MODE3 (3 << 1)
> #define PIO2_CNTR_MODE4 (4 << 1)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-21 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-21 5:52 [PATCH] staging:vme Fix use BIT macro Janani Sankara Babu
2017-09-21 11:49 ` Martyn Welch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®