* [PATCH] staging:ccree Fix use BIT macro
@ 2017-09-21 6:39 Janani Sankara Babu
2017-09-24 7:20 ` Gilad Ben-Yossef
0 siblings, 1 reply; 2+ messages in thread
From: Janani Sankara Babu @ 2017-09-21 6:39 UTC (permalink / raw)
To: gregkh
Cc: gilad, linux-crypto, driverdev-devel, devel, linux-kernel,
Janani Sankara Babu
This patch is created to solve the following warning shown by the checkpatch
script Warning: Replace all occurences of (1<<x) by BIT(x)
Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
index 296b375..6fbcf9d 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/drivers/staging/ccree/ssi_cipher.h
@@ -27,11 +27,11 @@
#include "ssi_buffer_mgr.h"
/* Crypto cipher flags */
-#define CC_CRYPTO_CIPHER_KEY_KFDE0 (1 << 0)
-#define CC_CRYPTO_CIPHER_KEY_KFDE1 (1 << 1)
-#define CC_CRYPTO_CIPHER_KEY_KFDE2 (1 << 2)
-#define CC_CRYPTO_CIPHER_KEY_KFDE3 (1 << 3)
-#define CC_CRYPTO_CIPHER_DU_SIZE_512B (1 << 4)
+#define CC_CRYPTO_CIPHER_KEY_KFDE0 BIT(0)
+#define CC_CRYPTO_CIPHER_KEY_KFDE1 BIT(1)
+#define CC_CRYPTO_CIPHER_KEY_KFDE2 BIT(2)
+#define CC_CRYPTO_CIPHER_KEY_KFDE3 BIT(3)
+#define CC_CRYPTO_CIPHER_DU_SIZE_512B BIT(4)
#define CC_CRYPTO_CIPHER_KEY_KFDE_MASK (CC_CRYPTO_CIPHER_KEY_KFDE0 | CC_CRYPTO_CIPHER_KEY_KFDE1 | CC_CRYPTO_CIPHER_KEY_KFDE2 | CC_CRYPTO_CIPHER_KEY_KFDE3)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging:ccree Fix use BIT macro
2017-09-21 6:39 [PATCH] staging:ccree Fix use BIT macro Janani Sankara Babu
@ 2017-09-24 7:20 ` Gilad Ben-Yossef
0 siblings, 0 replies; 2+ messages in thread
From: Gilad Ben-Yossef @ 2017-09-24 7:20 UTC (permalink / raw)
To: Janani Sankara Babu
Cc: Greg Kroah-Hartman, Linux Crypto Mailing List, driverdev-devel,
devel, Linux kernel mailing list
Hi Janani,
On Thu, Sep 21, 2017 at 9:39 AM, Janani Sankara Babu
<jananis37@gmail.com> wrote:
> This patch is created to solve the following warning shown by the checkpatch
> script Warning: Replace all occurences of (1<<x) by BIT(x)
>
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
Thank you for the patch - unfortunately, such a fix s already present
in the staging-next tree.
I suggest you base your patches to ccree on that tree as it is the
most current for this driver.
Thanks again,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-24 7:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-21 6:39 [PATCH] staging:ccree Fix use BIT macro Janani Sankara Babu
2017-09-24 7:20 ` Gilad Ben-Yossef
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®