* [PATCH 1/5] crypto: omap-aes: pr_err() strings should end with newlines
2017-09-25 10:36 [PATCH 0/5] crypto pr_err() strings should end with newlines Arvind Yadav
@ 2017-09-25 10:36 ` Arvind Yadav
2017-09-25 10:36 ` [PATCH 2/5] crypto: virtio: " Arvind Yadav
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-09-25 10:36 UTC (permalink / raw)
To: herbert, davem, mst, jasowang, arei.gonglei, harsh,
giovanni.cabiddu, salvatore.benedetto
Cc: linux-crypto, linux-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/omap-aes-gcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/omap-aes-gcm.c b/drivers/crypto/omap-aes-gcm.c
index 7d4f8a4..9f8a1f7 100644
--- a/drivers/crypto/omap-aes-gcm.c
+++ b/drivers/crypto/omap-aes-gcm.c
@@ -214,7 +214,7 @@ static int do_encrypt_iv(struct aead_request *req, u32 *tag, u32 *iv)
}
/* fall through */
default:
- pr_err("Encryption of IV failed for GCM mode");
+ pr_err("Encryption of IV failed for GCM mode\n");
break;
}
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/5] crypto: virtio: pr_err() strings should end with newlines
2017-09-25 10:36 [PATCH 0/5] crypto pr_err() strings should end with newlines Arvind Yadav
2017-09-25 10:36 ` [PATCH 1/5] crypto: omap-aes: " Arvind Yadav
@ 2017-09-25 10:36 ` Arvind Yadav
2017-09-25 10:36 ` [PATCH 3/5] crypto: chelsio: " Arvind Yadav
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-09-25 10:36 UTC (permalink / raw)
To: herbert, davem, mst, jasowang, arei.gonglei, harsh,
giovanni.cabiddu, salvatore.benedetto
Cc: linux-crypto, linux-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/virtio/virtio_crypto_algs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c
index 5035b0d..abe8c15 100644
--- a/drivers/crypto/virtio/virtio_crypto_algs.c
+++ b/drivers/crypto/virtio/virtio_crypto_algs.c
@@ -319,7 +319,7 @@ static int virtio_crypto_ablkcipher_setkey(struct crypto_ablkcipher *tfm,
struct virtio_crypto *vcrypto =
virtcrypto_get_dev_node(node);
if (!vcrypto) {
- pr_err("virtio_crypto: Could not find a virtio device in the system");
+ pr_err("virtio_crypto: Could not find a virtio device in the system\n");
return -ENODEV;
}
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/5] crypto: chelsio: pr_err() strings should end with newlines
2017-09-25 10:36 [PATCH 0/5] crypto pr_err() strings should end with newlines Arvind Yadav
2017-09-25 10:36 ` [PATCH 1/5] crypto: omap-aes: " Arvind Yadav
2017-09-25 10:36 ` [PATCH 2/5] crypto: virtio: " Arvind Yadav
@ 2017-09-25 10:36 ` Arvind Yadav
2017-09-25 10:36 ` [PATCH 4/5] crypto: qat: " Arvind Yadav
2017-09-25 10:36 ` [PATCH 5/5] crypto: bcm: " Arvind Yadav
4 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-09-25 10:36 UTC (permalink / raw)
To: herbert, davem, mst, jasowang, arei.gonglei, harsh,
giovanni.cabiddu, salvatore.benedetto
Cc: linux-crypto, linux-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/chelsio/chcr_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/chelsio/chcr_core.c b/drivers/crypto/chelsio/chcr_core.c
index b6dd9cb..32618bf 100644
--- a/drivers/crypto/chelsio/chcr_core.c
+++ b/drivers/crypto/chelsio/chcr_core.c
@@ -224,7 +224,7 @@ static int chcr_uld_state_change(void *handle, enum cxgb4_state state)
static int __init chcr_crypto_init(void)
{
if (cxgb4_register_uld(CXGB4_ULD_CRYPTO, &chcr_uld_info))
- pr_err("ULD register fail: No chcr crypto support in cxgb4");
+ pr_err("ULD register fail: No chcr crypto support in cxgb4\n");
return 0;
}
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 4/5] crypto: qat: pr_err() strings should end with newlines
2017-09-25 10:36 [PATCH 0/5] crypto pr_err() strings should end with newlines Arvind Yadav
` (2 preceding siblings ...)
2017-09-25 10:36 ` [PATCH 3/5] crypto: chelsio: " Arvind Yadav
@ 2017-09-25 10:36 ` Arvind Yadav
2017-09-25 10:36 ` [PATCH 5/5] crypto: bcm: " Arvind Yadav
4 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-09-25 10:36 UTC (permalink / raw)
To: herbert, davem, mst, jasowang, arei.gonglei, harsh,
giovanni.cabiddu, salvatore.benedetto
Cc: linux-crypto, linux-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/qat/qat_common/qat_uclo.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/qat/qat_common/qat_uclo.c b/drivers/crypto/qat/qat_common/qat_uclo.c
index e2454d9..399604c 100644
--- a/drivers/crypto/qat/qat_common/qat_uclo.c
+++ b/drivers/crypto/qat/qat_common/qat_uclo.c
@@ -567,26 +567,26 @@ static unsigned int qat_uclo_calc_str_checksum(char *ptr, int num)
code_page->imp_expr_tab_offset);
if (uc_var_tab->entry_num || imp_var_tab->entry_num ||
imp_expr_tab->entry_num) {
- pr_err("QAT: UOF can't contain imported variable to be parsed");
+ pr_err("QAT: UOF can't contain imported variable to be parsed\n");
return -EINVAL;
}
neigh_reg_tab = (struct icp_qat_uof_objtable *)
(encap_uof_obj->beg_uof +
code_page->neigh_reg_tab_offset);
if (neigh_reg_tab->entry_num) {
- pr_err("QAT: UOF can't contain shared control store feature");
+ pr_err("QAT: UOF can't contain shared control store feature\n");
return -EINVAL;
}
if (image->numpages > 1) {
- pr_err("QAT: UOF can't contain multiple pages");
+ pr_err("QAT: UOF can't contain multiple pages\n");
return -EINVAL;
}
if (ICP_QAT_SHARED_USTORE_MODE(image->ae_mode)) {
- pr_err("QAT: UOF can't use shared control store feature");
+ pr_err("QAT: UOF can't use shared control store feature\n");
return -EFAULT;
}
if (RELOADABLE_CTX_SHARED_MODE(image->ae_mode)) {
- pr_err("QAT: UOF can't use reloadable feature");
+ pr_err("QAT: UOF can't use reloadable feature\n");
return -EFAULT;
}
return 0;
@@ -702,7 +702,7 @@ static int qat_uclo_map_ae(struct icp_qat_fw_loader_handle *handle, int max_ae)
}
}
if (!mflag) {
- pr_err("QAT: uimage uses AE not set");
+ pr_err("QAT: uimage uses AE not set\n");
return -EINVAL;
}
return 0;
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 5/5] crypto: bcm: pr_err() strings should end with newlines
2017-09-25 10:36 [PATCH 0/5] crypto pr_err() strings should end with newlines Arvind Yadav
` (3 preceding siblings ...)
2017-09-25 10:36 ` [PATCH 4/5] crypto: qat: " Arvind Yadav
@ 2017-09-25 10:36 ` Arvind Yadav
4 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-09-25 10:36 UTC (permalink / raw)
To: herbert, davem, mst, jasowang, arei.gonglei, harsh,
giovanni.cabiddu, salvatore.benedetto
Cc: linux-crypto, linux-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/crypto/bcm/util.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/bcm/util.c b/drivers/crypto/bcm/util.c
index 430c557..d543c01 100644
--- a/drivers/crypto/bcm/util.c
+++ b/drivers/crypto/bcm/util.c
@@ -271,7 +271,7 @@ int do_shash(unsigned char *name, unsigned char *result,
hash = crypto_alloc_shash(name, 0, 0);
if (IS_ERR(hash)) {
rc = PTR_ERR(hash);
- pr_err("%s: Crypto %s allocation error %d", __func__, name, rc);
+ pr_err("%s: Crypto %s allocation error %d\n", __func__, name, rc);
return rc;
}
@@ -279,7 +279,7 @@ int do_shash(unsigned char *name, unsigned char *result,
sdesc = kmalloc(size, GFP_KERNEL);
if (!sdesc) {
rc = -ENOMEM;
- pr_err("%s: Memory allocation failure", __func__);
+ pr_err("%s: Memory allocation failure\n", __func__);
goto do_shash_err;
}
sdesc->shash.tfm = hash;
@@ -288,31 +288,31 @@ int do_shash(unsigned char *name, unsigned char *result,
if (key_len > 0) {
rc = crypto_shash_setkey(hash, key, key_len);
if (rc) {
- pr_err("%s: Could not setkey %s shash", __func__, name);
+ pr_err("%s: Could not setkey %s shash\n", __func__, name);
goto do_shash_err;
}
}
rc = crypto_shash_init(&sdesc->shash);
if (rc) {
- pr_err("%s: Could not init %s shash", __func__, name);
+ pr_err("%s: Could not init %s shash\n", __func__, name);
goto do_shash_err;
}
rc = crypto_shash_update(&sdesc->shash, data1, data1_len);
if (rc) {
- pr_err("%s: Could not update1", __func__);
+ pr_err("%s: Could not update1\n", __func__);
goto do_shash_err;
}
if (data2 && data2_len) {
rc = crypto_shash_update(&sdesc->shash, data2, data2_len);
if (rc) {
- pr_err("%s: Could not update2", __func__);
+ pr_err("%s: Could not update2\n", __func__);
goto do_shash_err;
}
}
rc = crypto_shash_final(&sdesc->shash, result);
if (rc)
- pr_err("%s: Could not generate %s hash", __func__, name);
+ pr_err("%s: Could not generate %s hash\n", __func__, name);
do_shash_err:
crypto_free_shash(hash);
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread