From: Sudeep Holla <sudeep.holla@arm.com>
To: ALKML <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Roy Franz <roy.franz@cavium.com>,
Harb Abdulhamid <harba@codeaurora.org>,
Nishanth Menon <nm@ti.com>, Arnd Bergmann <arnd@arndb.de>,
Loc Ho <lho@apm.com>, Alexey Klimov <alexey.klimov@arm.com>,
Ryan Harkin <Ryan.Harkin@arm.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Subject: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface
Date: Thu, 28 Sep 2017 14:11:40 +0100 [thread overview]
Message-ID: <1506604306-20739-17-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <1506604306-20739-1-git-send-email-sudeep.holla@arm.com>
This patch adds ARM MHU specific mailbox interface for SCMI.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/firmware/arm_scmi/Makefile | 1 +
drivers/firmware/arm_scmi/arm_mhu_if.c | 106 +++++++++++++++++++++++++++++++++
drivers/firmware/arm_scmi/driver.c | 3 +
drivers/firmware/arm_scmi/mbox_if.h | 3 +
4 files changed, 113 insertions(+)
create mode 100644 drivers/firmware/arm_scmi/arm_mhu_if.c
diff --git a/drivers/firmware/arm_scmi/Makefile b/drivers/firmware/arm_scmi/Makefile
index 733157c5b4e2..7fb026c71833 100644
--- a/drivers/firmware/arm_scmi/Makefile
+++ b/drivers/firmware/arm_scmi/Makefile
@@ -1,2 +1,3 @@
obj-$(CONFIG_ARM_SCMI_PROTOCOL) = arm_scmi.o
arm_scmi-y = base.o clock.o driver.o mbox_if.o perf.o power.o sensors.o
+arm_scmi-$(CONFIG_ARM_MHU) += arm_mhu_if.o
diff --git a/drivers/firmware/arm_scmi/arm_mhu_if.c b/drivers/firmware/arm_scmi/arm_mhu_if.c
new file mode 100644
index 000000000000..2271a4811378
--- /dev/null
+++ b/drivers/firmware/arm_scmi/arm_mhu_if.c
@@ -0,0 +1,106 @@
+/*
+ * System Control and Management Interface (SCMI) MHU mailbox interface
+ *
+ * Copyright (C) 2017 ARM Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <linux/of.h>
+#include <linux/platform_device.h>
+
+#include "common.h"
+#include "mbox_if.h"
+
+union mhu_data {
+ void *ptr;
+ u32 val;
+};
+
+static void mhu_tx_prepare(struct mbox_client *cl, void *m)
+{
+ struct scmi_chan_info *cinfo = client_to_scmi_chan_info(cl);
+ union mhu_data tmp;
+
+ scmi_generic_tx_prepare(cinfo, m);
+
+ /* clear only the relavant bit */
+ tmp.ptr = cinfo->priv;
+ *(u32 *)m &= tmp.val;
+}
+
+static void mhu_rx_callback(struct mbox_client *cl, void *m)
+{
+ struct scmi_chan_info *cinfo = client_to_scmi_chan_info(cl);
+
+ scmi_generic_rx_callback(cinfo);
+}
+
+static int mhu_mbox_request_channel(struct scmi_chan_info *cinfo, int index)
+{
+ int ret = 0;
+ struct mbox_client *cl = &cinfo->cl;
+ struct device_node *np = cl->dev->of_node;
+ union mhu_data tmp = {0};
+
+ if (index != 0 && index != 1) /* Tx = 0, Rx =1 */
+ return -EINVAL;
+
+ cl->rx_callback = mhu_rx_callback;
+ cl->tx_prepare = mhu_tx_prepare;
+
+ ret = of_property_read_u32_index(np, "mbox-data", index, &tmp.val);
+ if (ret)
+ return ret;
+
+ cinfo->chan = mbox_request_channel(cl, index);
+ if (IS_ERR(cinfo->chan))
+ ret = PTR_ERR(cinfo->chan);
+
+ cinfo->priv = tmp.ptr;
+
+ return ret;
+}
+
+static int mhu_mbox_send_message(struct scmi_chan_info *cinfo, void *msg)
+{
+ struct scmi_xfer *t = msg;
+
+ t->con_priv = cinfo->priv;
+
+ return mbox_send_message(cinfo->chan, msg);
+}
+
+static void mhu_mbox_client_txdone(struct scmi_chan_info *cinfo, int r)
+{
+ mbox_client_txdone(cinfo->chan, r);
+}
+
+static void mhu_mbox_free_channel(struct scmi_chan_info *cinfo)
+{
+ mbox_free_channel(cinfo->chan);
+}
+
+static struct scmi_mbox_ops arm_mhu_mbox_ops = {
+ .request_channel = mhu_mbox_request_channel,
+ .send_message = mhu_mbox_send_message,
+ .client_txdone = mhu_mbox_client_txdone,
+ .free_channel = mhu_mbox_free_channel,
+};
+
+const struct scmi_desc mhu_scmi_desc = {
+ .max_rx_timeout_ms = 30,
+ .max_msg = 20,
+ .max_msg_size = 128,
+ .mbox_ops = &arm_mhu_mbox_ops,
+};
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index 97285a22dfaa..bdc9c566e6c1 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -648,6 +648,9 @@ EXPORT_SYMBOL_GPL(devm_scmi_handle_get);
/* Each compatible listed below must have descriptor associated with it */
static const struct of_device_id scmi_of_match[] = {
{ .compatible = "arm,scmi", .data = &scmi_generic_desc },
+#if IS_REACHABLE(CONFIG_ARM_MHU)
+ { .compatible = "arm,mhu-scmi", .data = &mhu_scmi_desc },
+#endif
{ /* Sentinel */ },
};
diff --git a/drivers/firmware/arm_scmi/mbox_if.h b/drivers/firmware/arm_scmi/mbox_if.h
index 02baa73e8613..a23fc6d7a91f 100644
--- a/drivers/firmware/arm_scmi/mbox_if.h
+++ b/drivers/firmware/arm_scmi/mbox_if.h
@@ -66,3 +66,6 @@ void scmi_generic_rx_callback(struct scmi_chan_info *cinfo);
void scmi_generic_tx_prepare(struct scmi_chan_info *cinfo, void *m);
extern const struct scmi_desc scmi_generic_desc;
+#if IS_REACHABLE(CONFIG_ARM_MHU)
+extern const struct scmi_desc mhu_scmi_desc;
+#endif
--
2.7.4
next prev parent reply other threads:[~2017-09-28 13:14 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 13:11 [PATCH v3 00/22] firmware: ARM System Control and Management Interface(SCMI) support Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 01/22] dt-bindings: mailbox: add support for mailbox client shared memory Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 02/22] dt-bindings: arm: add support for ARM System Control and Management Interface(SCMI) protocol Sudeep Holla
2017-10-04 10:50 ` Arnd Bergmann
2017-10-04 11:07 ` Sudeep Holla
2017-10-04 12:35 ` Arnd Bergmann
2017-10-04 13:53 ` Sudeep Holla
2017-10-04 14:17 ` Arnd Bergmann
2017-10-04 14:47 ` Sudeep Holla
2017-10-05 11:56 ` Arnd Bergmann
2017-10-05 12:56 ` Sudeep Holla
2017-10-05 13:20 ` Jassi Brar
2017-10-05 14:10 ` Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings Sudeep Holla
2017-10-05 23:20 ` Rob Herring
2017-10-06 9:42 ` Sudeep Holla
2017-10-06 11:01 ` Jassi Brar
2017-10-06 15:54 ` Rob Herring
2017-10-07 2:26 ` Jassi Brar
2017-10-09 13:52 ` Rob Herring
2017-10-09 14:37 ` Sudeep Holla
2017-10-09 14:46 ` Jassi Brar
2017-10-09 22:57 ` Rob Herring
2017-10-10 1:52 ` Jassi Brar
2017-10-10 11:04 ` Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 04/22] firmware: arm_scmi: add basic driver infrastructure for SCMI Sudeep Holla
2017-10-04 10:59 ` Arnd Bergmann
2017-10-04 17:37 ` Sudeep Holla
2017-10-04 11:19 ` Arnd Bergmann
2017-09-28 13:11 ` [PATCH v3 05/22] firmware: arm_scmi: add common infrastructure and support for base protocol Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 06/22] firmware: arm_scmi: add initial support for performance protocol Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 07/22] firmware: arm_scmi: add initial support for clock protocol Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 08/22] firmware: arm_scmi: add initial support for power protocol Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 09/22] firmware: arm_scmi: add initial support for sensor protocol Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 10/22] firmware: arm_scmi: probe and initialise all the supported protocols Sudeep Holla
2017-10-04 11:06 ` Arnd Bergmann
2017-09-28 13:11 ` [PATCH v3 11/22] firmware: arm_scmi: add support for polling based SCMI transfers Sudeep Holla
2017-10-04 11:13 ` Arnd Bergmann
2017-10-04 11:18 ` Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 12/22] firmware: arm_scmi: add option for polling based performance domain operations Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 13/22] firmware: arm_scmi: refactor in preparation to support per-protocol channels Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 14/22] firmware: arm_scmi: add per-protocol channels support using idr objects Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 15/22] firmware: arm_scmi: abstract mailbox interface Sudeep Holla
2017-10-04 11:24 ` Arnd Bergmann
2017-10-04 11:32 ` Sudeep Holla
2017-10-06 11:34 ` Jassi Brar
2017-10-06 13:27 ` Sudeep Holla
2017-10-06 13:34 ` Jassi Brar
2017-10-06 13:41 ` Sudeep Holla
2017-10-12 21:20 ` Bjorn Andersson
2017-09-28 13:11 ` Sudeep Holla [this message]
2017-10-04 11:36 ` [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific " Arnd Bergmann
2017-10-04 11:48 ` Sudeep Holla
2017-10-06 11:26 ` Jassi Brar
2017-10-06 13:32 ` Sudeep Holla
2017-10-06 13:47 ` Jassi Brar
2017-10-06 13:51 ` Sudeep Holla
2017-10-12 21:03 ` Bjorn Andersson
2017-10-13 13:42 ` Sudeep Holla
2017-10-13 14:12 ` Jassi Brar
2017-10-13 14:47 ` Sudeep Holla
2017-10-13 15:19 ` Jassi Brar
2017-09-28 13:11 ` [PATCH v3 17/22] firmware: arm_scmi: add device power domain support using genpd Sudeep Holla
2017-09-28 21:18 ` Ulf Hansson
2017-09-29 13:40 ` Sudeep Holla
2017-09-29 13:42 ` [PATCH v3 17/22][UPDATE] firmware: arm_scmi: add device power domain support genpd Sudeep Holla
2017-10-10 11:05 ` Ulf Hansson
2017-10-10 13:02 ` Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 18/22] clk: add support for clocks provided by SCMI Sudeep Holla
2017-11-02 7:23 ` Stephen Boyd
2017-11-02 10:04 ` Sudeep Holla
2017-11-03 15:12 ` Stephen Boyd
2017-09-28 13:11 ` [PATCH v3 19/22] hwmon: (core) Add hwmon_max to hwmon_sensor_types enumeration Sudeep Holla
2017-10-01 14:21 ` [v3, " Guenter Roeck
2017-09-28 13:11 ` [PATCH v3 20/22] hwmon: add support for sensors exported via ARM SCMI Sudeep Holla
2017-10-01 14:26 ` [v3,20/22] " Guenter Roeck
2017-10-02 9:25 ` Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 21/22] cpufreq: add support for CPU DVFS based on SCMI message protocol Sudeep Holla
2017-10-04 11:30 ` Arnd Bergmann
2017-10-04 15:01 ` Sudeep Holla
2017-10-05 11:20 ` Arnd Bergmann
2017-10-05 11:26 ` Sudeep Holla
2017-09-28 13:11 ` [PATCH v3 22/22] cpufreq: scmi: add support for fast frequency switching Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506604306-20739-17-git-send-email-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=Ryan.Harkin@arm.com \
--cc=alexey.klimov@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=harba@codeaurora.org \
--cc=jassisinghbrar@gmail.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=roy.franz@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®