* [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j
@ 2017-09-29 13:52 Colin King
2017-09-29 15:27 ` Doug Ledford
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-09-29 13:52 UTC (permalink / raw)
To: Lijun Ou, Wei Hu, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable j is being assigned to loop_j and then later being
assigned to a new value in for loops. The first initialization
is therefore redundant and can be removed.
Cleans up clang warning:
warning: Value stored to 'j' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/hns/hns_roce_mr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c
index 7e6ce76b32df..452136d98ad5 100644
--- a/drivers/infiniband/hw/hns/hns_roce_mr.c
+++ b/drivers/infiniband/hw/hns/hns_roce_mr.c
@@ -272,7 +272,6 @@ static void hns_roce_loop_free(struct hns_roce_dev *hr_dev,
mhop_num = hr_dev->caps.pbl_hop_num;
i = loop_i;
- j = loop_j;
if (mhop_num == 3 && err_loop_index == 2) {
for (; i >= 0; i--) {
dma_free_coherent(dev, pbl_bt_sz, mr->pbl_bt_l1[i],
--
2.14.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j
2017-09-29 13:52 [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j Colin King
@ 2017-09-29 15:27 ` Doug Ledford
0 siblings, 0 replies; 2+ messages in thread
From: Doug Ledford @ 2017-09-29 15:27 UTC (permalink / raw)
To: Colin King, Lijun Ou, Wei Hu, Sean Hefty, Hal Rosenstock, linux-rdma
Cc: kernel-janitors, linux-kernel
On Fri, 2017-09-29 at 14:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable j is being assigned to loop_j and then later being
> assigned to a new value in for loops. The first initialization
> is therefore redundant and can be removed.
>
> Cleans up clang warning:
> warning: Value stored to 'j' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-29 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29 13:52 [PATCH][rdma-next] RDMA/hns: remove redundant assignment to variable j Colin King
2017-09-29 15:27 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome