From: Mateusz Guzik <mguzik@redhat.com>
To: Eric Dumazet <edumazet@google.com>, Al Viro <viro@zeniv.linux.org.uk>
Cc: mszeredi@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] vfs: stop clearing close on exec when closing a fd
Date: Tue, 3 Oct 2017 12:58:14 +0200 [thread overview]
Message-ID: <1507028295-9353-2-git-send-email-mguzik@redhat.com> (raw)
In-Reply-To: <1507028295-9353-1-git-send-email-mguzik@redhat.com>
Codepaths allocating a fd always make sure the bit is set/unset
depending on flags, thus clearing on close is redundant.
Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
---
fs/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/file.c b/fs/file.c
index 1fc7fbb..9d047bd 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -631,7 +631,6 @@ int __close_fd(struct files_struct *files, unsigned fd)
if (!file)
goto out_unlock;
rcu_assign_pointer(fdt->fd[fd], NULL);
- __clear_close_on_exec(fd, fdt);
__put_unused_fd(files, fd);
spin_unlock(&files->file_lock);
return filp_close(file, files);
--
1.8.3.1
next prev parent reply other threads:[~2017-10-03 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 10:58 [PATCH 0/2] minor fd cleanup Mateusz Guzik
2017-10-03 10:58 ` Mateusz Guzik [this message]
2017-10-03 14:39 ` [PATCH 1/2] vfs: stop clearing close on exec when closing a fd Eric Dumazet
2017-10-03 10:58 ` [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing Mateusz Guzik
2017-10-03 14:41 ` Eric Dumazet
2017-10-04 13:55 ` Matthew Wilcox
2017-10-04 14:00 ` Eric Dumazet
2017-10-04 14:58 ` Matthew Wilcox
2017-10-04 15:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507028295-9353-2-git-send-email-mguzik@redhat.com \
--to=mguzik@redhat.com \
--cc=edumazet@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome