From: Matthew Wilcox <willy@infradead.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Mateusz Guzik <mguzik@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
mszeredi@redhat.com, linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing
Date: Wed, 4 Oct 2017 06:55:41 -0700 [thread overview]
Message-ID: <20171004135541.GA22253@bombadil.infradead.org> (raw)
In-Reply-To: <CANn89iLNATFw_q2KVsmCq+gtu3LbJ6mz-5JqgrNnwvsZUz5D+g@mail.gmail.com>
On Tue, Oct 03, 2017 at 07:41:11AM -0700, Eric Dumazet wrote:
> On Tue, Oct 3, 2017 at 3:58 AM, Mateusz Guzik <mguzik@redhat.com> wrote:
> > Explicit locking in the fallback case provides a safe state of the
> > table. Getting rid of blocking semantics makes __fd_install usable
> > again in non-sleepable contexts, which easies backporting efforts.
> >
> > There is a side effect of slightly nicer assembly for the common case
> > as might_sleep can now be removed.
> >
> > Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
> > ---
> > Documentation/filesystems/porting | 4 ----
> > fs/file.c | 11 +++++++----
> > 2 files changed, 7 insertions(+), 8 deletions(-)
>
> Nice change !
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
Hey Eric,
Any chance you could review the patches from Sandhya that make this entire
codepath obsolete?
https://lkml.org/lkml/2017/4/29/20
next prev parent reply other threads:[~2017-10-04 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 10:58 [PATCH 0/2] minor fd cleanup Mateusz Guzik
2017-10-03 10:58 ` [PATCH 1/2] vfs: stop clearing close on exec when closing a fd Mateusz Guzik
2017-10-03 14:39 ` Eric Dumazet
2017-10-03 10:58 ` [PATCH 2/2] vfs: grab the lock instead of blocking in __fd_install during resizing Mateusz Guzik
2017-10-03 14:41 ` Eric Dumazet
2017-10-04 13:55 ` Matthew Wilcox [this message]
2017-10-04 14:00 ` Eric Dumazet
2017-10-04 14:58 ` Matthew Wilcox
2017-10-04 15:04 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004135541.GA22253@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=edumazet@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=mszeredi@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®