* [PATCH] kbuild: Fix optimization level choice default
@ 2017-10-03 23:53 Ulf Magnusson
2017-10-04 7:27 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Magnusson @ 2017-10-03 23:53 UTC (permalink / raw)
To: linux-kernel
Cc: linux-kbuild, paulmck, nicolas.pitre, akpm, tj, tglx, keescook,
daniel, arnd, Ulf Magnusson
The choice containing the CC_OPTIMIZE_FOR_PERFORMANCE symbol
accidentally added a "CONFIG_" prefix when trying to make it the
default, selecting an undefined symbol as the default.
The mistake is harmless here: Since the default symbol is not visible,
the choice falls back on using the visible symbol as the default
instead, which is CC_OPTIMIZE_FOR_PERFORMANCE, as intended.
A patch that makes Kconfig print a warning in this case has been
submitted separately:
http://www.spinics.net/lists/linux-kbuild/msg15566.html
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
init/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/Kconfig b/init/Kconfig
index 78cb246..3c1faaa 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1033,7 +1033,7 @@ endif
choice
prompt "Compiler optimization level"
- default CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE
+ default CC_OPTIMIZE_FOR_PERFORMANCE
config CC_OPTIMIZE_FOR_PERFORMANCE
bool "Optimize for performance"
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kbuild: Fix optimization level choice default
2017-10-03 23:53 [PATCH] kbuild: Fix optimization level choice default Ulf Magnusson
@ 2017-10-04 7:27 ` Arnd Bergmann
2017-10-05 20:04 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-10-04 7:27 UTC (permalink / raw)
To: Ulf Magnusson
Cc: Linux Kernel Mailing List, Linux Kbuild mailing list,
Paul E. McKenney, Nicolas Pitre, Andrew Morton, Tejun Heo,
Thomas Gleixner, Kees Cook, Daniel Mack
On Wed, Oct 4, 2017 at 1:53 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
> The choice containing the CC_OPTIMIZE_FOR_PERFORMANCE symbol
> accidentally added a "CONFIG_" prefix when trying to make it the
> default, selecting an undefined symbol as the default.
>
> The mistake is harmless here: Since the default symbol is not visible,
> the choice falls back on using the visible symbol as the default
> instead, which is CC_OPTIMIZE_FOR_PERFORMANCE, as intended.
>
> A patch that makes Kconfig print a warning in this case has been
> submitted separately:
> http://www.spinics.net/lists/linux-kbuild/msg15566.html
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kbuild: Fix optimization level choice default
2017-10-04 7:27 ` Arnd Bergmann
@ 2017-10-05 20:04 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2017-10-05 20:04 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ulf Magnusson, Linux Kernel Mailing List,
Linux Kbuild mailing list, Paul E. McKenney, Nicolas Pitre,
Andrew Morton, Tejun Heo, Thomas Gleixner, Kees Cook,
Daniel Mack
2017-10-04 16:27 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> On Wed, Oct 4, 2017 at 1:53 AM, Ulf Magnusson <ulfalizer@gmail.com> wrote:
>> The choice containing the CC_OPTIMIZE_FOR_PERFORMANCE symbol
>> accidentally added a "CONFIG_" prefix when trying to make it the
>> default, selecting an undefined symbol as the default.
>>
>> The mistake is harmless here: Since the default symbol is not visible,
>> the choice falls back on using the visible symbol as the default
>> instead, which is CC_OPTIMIZE_FOR_PERFORMANCE, as intended.
>>
>> A patch that makes Kconfig print a warning in this case has been
>> submitted separately:
>> http://www.spinics.net/lists/linux-kbuild/msg15566.html
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> --
Applied to linux-kbuild/fixes. Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-05 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03 23:53 [PATCH] kbuild: Fix optimization level choice default Ulf Magnusson
2017-10-04 7:27 ` Arnd Bergmann
2017-10-05 20:04 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®