From: Stephen Smalley <sds@tycho.nsa.gov>
To: Corentin Labbe <clabbe.montjoie@gmail.com>,
paul@paul-moore.com, eparis@parisplace.org,
james.l.morris@oracle.com, serge@hallyn.com
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH 2/2] selinux: fix build warning
Date: Wed, 04 Oct 2017 16:27:52 -0400 [thread overview]
Message-ID: <1507148872.1491.11.camel@tycho.nsa.gov> (raw)
In-Reply-To: <20171004183218.4786-2-clabbe.montjoie@gmail.com>
On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch make selinux_task_prlimit() static since it is not used
> anywhere else.
> This fix the following build warning:
> security/selinux/hooks.c:3981:5: warning: no previous prototype for
> 'selinux_task_prlimit' [-Wmissing-prototypes]
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/hooks.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 8507a56f85e4..b8a022f4b4a7 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct
> task_struct *p)
> PROCESS__GETSCHED, NULL);
> }
>
> -int selinux_task_prlimit(const struct cred *cred, const struct cred
> *tcred,
> - unsigned int flags)
> +static int selinux_task_prlimit(const struct cred *cred, const
> struct cred *tcred,
> + unsigned int flags)
> {
> u32 av = 0;
>
next prev parent reply other threads:[~2017-10-04 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:32 [PATCH 1/2] selinux: fix build warning by removing the unused sid variable Corentin Labbe
2017-10-04 18:32 ` [PATCH 2/2] selinux: fix build warning Corentin Labbe
2017-10-04 20:27 ` Stephen Smalley [this message]
2017-10-04 20:34 ` Paul Moore
2017-10-04 20:26 ` [PATCH 1/2] selinux: fix build warning by removing the unused sid variable Stephen Smalley
2017-10-04 20:33 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507148872.1491.11.camel@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=clabbe.montjoie@gmail.com \
--cc=eparis@parisplace.org \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@tycho.nsa.gov \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®