* [PATCH 2/2] Staging: rtl8723bs: Externs should be avoided in .C file
@ 2017-10-04 20:34 Srinivasan Shanmugam
2017-10-05 12:43 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Srinivasan Shanmugam @ 2017-10-04 20:34 UTC (permalink / raw)
To: gregkh, devel, linux-kernel; +Cc: Srinivasan Shanmugam
Removed all the unnecessary extern from rtl8723bs
Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index c0b501e..6b5e48c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1226,7 +1226,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
-static sint validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame)
+static int validate_recv_mgnt_frame(struct adapter *padapter,
+ union recv_frame *precv_frame)
{
/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] Staging: rtl8723bs: Externs should be avoided in .C file
2017-10-04 20:34 [PATCH 2/2] Staging: rtl8723bs: Externs should be avoided in .C file Srinivasan Shanmugam
@ 2017-10-05 12:43 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-10-05 12:43 UTC (permalink / raw)
To: Srinivasan Shanmugam; +Cc: gregkh, devel, linux-kernel
On Wed, Oct 04, 2017 at 10:34:02PM +0200, Srinivasan Shanmugam wrote:
> Removed all the unnecessary extern from rtl8723bs
>
The patch is good but doesn't match the description.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-05 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04 20:34 [PATCH 2/2] Staging: rtl8723bs: Externs should be avoided in .C file Srinivasan Shanmugam
2017-10-05 12:43 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®