* [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info
@ 2017-10-10 10:05 Rajneesh Bhardwaj
2017-10-10 10:05 ` [PATCH 2/3] platform/x86: intel_telemetry: Fix typos Rajneesh Bhardwaj
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rajneesh Bhardwaj @ 2017-10-10 10:05 UTC (permalink / raw)
To: platform-driver-x86
Cc: dvhart, andy, linux-kernel, souvik.k.chakravarty, Rajneesh Bhardwaj
Intel Telemetry driver depends on IPC1 interface. If IPC1 interface is
disabled on a given platform by the system firmware, the driver does not
load but prints misleading information in the dmesg logs.
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
---
drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index e0424d5a795a..136507a0d391 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -1234,7 +1234,6 @@ static struct platform_driver telemetry_soc_driver = {
static int __init telemetry_module_init(void)
{
- pr_info(DRIVER_NAME ": version %s loaded\n", DRIVER_VERSION);
return platform_driver_register(&telemetry_soc_driver);
}
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/3] platform/x86: intel_telemetry: Fix typos
2017-10-10 10:05 [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info Rajneesh Bhardwaj
@ 2017-10-10 10:05 ` Rajneesh Bhardwaj
2017-10-10 10:05 ` [PATCH 3/3] platform/x86: intel_telemetry: cleanup redundant headers Rajneesh Bhardwaj
2017-10-14 14:10 ` [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: Rajneesh Bhardwaj @ 2017-10-10 10:05 UTC (permalink / raw)
To: platform-driver-x86
Cc: dvhart, andy, linux-kernel, souvik.k.chakravarty, Rajneesh Bhardwaj
Telemetry word is misspelled several times in this file as Telemtry. This
fixes the spelling mistake and folds in another minor typo.
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
---
drivers/platform/x86/intel_telemetry_pltdrv.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 136507a0d391..3daf92e1282f 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -256,7 +256,7 @@ static int telemetry_check_evtid(enum telemetry_unit telem_unit,
break;
default:
- pr_err("Unknown Telemetry action Specified %d\n", action);
+ pr_err("Unknown Telemetry action specified %d\n", action);
return -EINVAL;
}
@@ -659,7 +659,7 @@ static int telemetry_setup(struct platform_device *pdev)
ret = telemetry_setup_evtconfig(pss_evtconfig, ioss_evtconfig,
TELEM_RESET);
if (ret) {
- dev_err(&pdev->dev, "TELEMTRY Setup Failed\n");
+ dev_err(&pdev->dev, "TELEMETRY Setup Failed\n");
return ret;
}
return 0;
@@ -685,7 +685,7 @@ static int telemetry_plt_update_events(struct telemetry_evtconfig pss_evtconfig,
ret = telemetry_setup_evtconfig(pss_evtconfig, ioss_evtconfig,
TELEM_UPDATE);
if (ret)
- pr_err("TELEMTRY Config Failed\n");
+ pr_err("TELEMETRY Config Failed\n");
return ret;
}
@@ -822,7 +822,7 @@ static int telemetry_plt_reset_events(void)
ret = telemetry_setup_evtconfig(pss_evtconfig, ioss_evtconfig,
TELEM_RESET);
if (ret)
- pr_err("TELEMTRY Reset Failed\n");
+ pr_err("TELEMETRY Reset Failed\n");
return ret;
}
@@ -885,7 +885,7 @@ static int telemetry_plt_add_events(u8 num_pss_evts, u8 num_ioss_evts,
ret = telemetry_setup_evtconfig(pss_evtconfig, ioss_evtconfig,
TELEM_ADD);
if (ret)
- pr_err("TELEMTRY ADD Failed\n");
+ pr_err("TELEMETRY ADD Failed\n");
return ret;
}
@@ -1195,7 +1195,7 @@ static int telemetry_pltdrv_probe(struct platform_device *pdev)
ret = telemetry_set_pltdata(&telm_pltops, telm_conf);
if (ret) {
- dev_err(&pdev->dev, "TELEMTRY Set Pltops Failed.\n");
+ dev_err(&pdev->dev, "TELEMETRY Set Pltops Failed.\n");
goto out;
}
@@ -1210,7 +1210,7 @@ static int telemetry_pltdrv_probe(struct platform_device *pdev)
iounmap(telm_conf->pss_config.regmap);
if (telm_conf->ioss_config.regmap)
iounmap(telm_conf->ioss_config.regmap);
- dev_err(&pdev->dev, "TELEMTRY Setup Failed.\n");
+ dev_err(&pdev->dev, "TELEMETRY Setup Failed.\n");
return ret;
}
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/3] platform/x86: intel_telemetry: cleanup redundant headers
2017-10-10 10:05 [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info Rajneesh Bhardwaj
2017-10-10 10:05 ` [PATCH 2/3] platform/x86: intel_telemetry: Fix typos Rajneesh Bhardwaj
@ 2017-10-10 10:05 ` Rajneesh Bhardwaj
2017-10-14 14:10 ` [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: Rajneesh Bhardwaj @ 2017-10-10 10:05 UTC (permalink / raw)
To: platform-driver-x86
Cc: dvhart, andy, linux-kernel, souvik.k.chakravarty, Rajneesh Bhardwaj
Removes unnecessary header files included in the driver and sorts the
remaining ones in the alphabetical order.
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
---
drivers/platform/x86/intel_telemetry_core.c | 3 +--
drivers/platform/x86/intel_telemetry_debugfs.c | 8 +++-----
drivers/platform/x86/intel_telemetry_pltdrv.c | 8 --------
3 files changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/platform/x86/intel_telemetry_core.c b/drivers/platform/x86/intel_telemetry_core.c
index 0d4c3808a6d8..f378621b5fe9 100644
--- a/drivers/platform/x86/intel_telemetry_core.c
+++ b/drivers/platform/x86/intel_telemetry_core.c
@@ -15,9 +15,8 @@
* Telemetry Framework provides platform related PM and performance statistics.
* This file provides the core telemetry API implementation.
*/
-#include <linux/module.h>
-#include <linux/init.h>
#include <linux/device.h>
+#include <linux/module.h>
#include <asm/intel_telemetry.h>
diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c
index d4fc42b4cbeb..6219a6541965 100644
--- a/drivers/platform/x86/intel_telemetry_debugfs.c
+++ b/drivers/platform/x86/intel_telemetry_debugfs.c
@@ -21,14 +21,12 @@
* /sys/kernel/debug/telemetry/ioss_race_verbosity: Write and Change Tracing
* Verbosity via firmware
*/
-#include <linux/module.h>
-#include <linux/init.h>
-#include <linux/device.h>
#include <linux/debugfs.h>
-#include <linux/seq_file.h>
+#include <linux/device.h>
#include <linux/io.h>
-#include <linux/uaccess.h>
+#include <linux/module.h>
#include <linux/pci.h>
+#include <linux/seq_file.h>
#include <linux/suspend.h>
#include <asm/cpu_device_id.h>
diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 3daf92e1282f..678abf2e9e92 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -17,14 +17,6 @@
* The accumulated results are fetched from SRAM.
*/
#include <linux/module.h>
-#include <linux/init.h>
-#include <linux/device.h>
-#include <linux/debugfs.h>
-#include <linux/seq_file.h>
-#include <linux/io.h>
-#include <linux/uaccess.h>
-#include <linux/pci.h>
-#include <linux/suspend.h>
#include <linux/platform_device.h>
#include <asm/cpu_device_id.h>
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info
2017-10-10 10:05 [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info Rajneesh Bhardwaj
2017-10-10 10:05 ` [PATCH 2/3] platform/x86: intel_telemetry: Fix typos Rajneesh Bhardwaj
2017-10-10 10:05 ` [PATCH 3/3] platform/x86: intel_telemetry: cleanup redundant headers Rajneesh Bhardwaj
@ 2017-10-14 14:10 ` Andy Shevchenko
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2017-10-14 14:10 UTC (permalink / raw)
To: Rajneesh Bhardwaj
Cc: Platform Driver, dvhart, Andy Shevchenko, linux-kernel,
Souvik Kumar Chakravarty
On Tue, Oct 10, 2017 at 1:05 PM, Rajneesh Bhardwaj
<rajneesh.bhardwaj@intel.com> wrote:
> Intel Telemetry driver depends on IPC1 interface. If IPC1 interface is
> disabled on a given platform by the system firmware, the driver does not
> load but prints misleading information in the dmesg logs.
All pushed to my review queue, thanks!
>
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> ---
> drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index e0424d5a795a..136507a0d391 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -1234,7 +1234,6 @@ static struct platform_driver telemetry_soc_driver = {
>
> static int __init telemetry_module_init(void)
> {
> - pr_info(DRIVER_NAME ": version %s loaded\n", DRIVER_VERSION);
> return platform_driver_register(&telemetry_soc_driver);
> }
>
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-14 14:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 10:05 [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info Rajneesh Bhardwaj
2017-10-10 10:05 ` [PATCH 2/3] platform/x86: intel_telemetry: Fix typos Rajneesh Bhardwaj
2017-10-10 10:05 ` [PATCH 3/3] platform/x86: intel_telemetry: cleanup redundant headers Rajneesh Bhardwaj
2017-10-14 14:10 ` [PATCH 1/3] platform/x86: intel_telemetry: Fix load failure info Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®