From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: David Airlie <airlied@linux.ie>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCH 1/9] drm/panel: simple: add a macro for defining display modes in a simpler and less error prone way
Date: Wed, 11 Oct 2017 13:23:33 +0200 [thread overview]
Message-ID: <1507721021-28174-2-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1507721021-28174-1-git-send-email-LW@KARO-electronics.de>
Create a macro that eases the definition of display mode parameters by
accecpting the parameters:
freq, hactive, hfront-porch, hsynclen, hback-porch,
vactive, vfront-porch, vsynclen, vback-porch, vrefresh
that can be usually directly taken from an LCD datasheet.
Put the calculations that are now open coded repeating the same
parameters multiple times into the macro expansion.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
drivers/gpu/drm/panel/panel-simple.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 474fa75..dec639d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -411,6 +411,20 @@ static const struct panel_desc ampire_am_480272h3tmqw_t01h = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};
+#define SP_DISPLAY_MODE(freq, ha, hfp, hs, hbp, va, vfp, vs, vbp, vr, flgs) { \
+ .clock = freq, \
+ .hdisplay = ha, \
+ .hsync_start = (ha) + (hfp), \
+ .hsync_end = (ha) + (hfp) + (hs), \
+ .htotal = (ha) + (hfp) + (hs) + (hbp), \
+ .vdisplay = (va), \
+ .vsync_start = (va) + (vfp), \
+ .vsync_end = (va) + (vfp) + (vs), \
+ .vtotal = (va) + (vfp) + (vs) + (vbp), \
+ .vrefresh = vr, \
+ .flags = flgs, \
+ }
+
static const struct drm_display_mode ampire_am800480r3tmqwa1h_mode = {
.clock = 33333,
.hdisplay = 800,
--
2.1.4
next prev parent reply other threads:[~2017-10-11 11:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 11:23 [PATCH 0/9] drm/panel: simple: improve definition of display modes and add more panels Lothar Waßmann
2017-10-11 11:23 ` Lothar Waßmann [this message]
2017-10-17 12:08 ` [PATCH 1/9] drm/panel: simple: add a macro for defining display modes in a simpler and less error prone way Thierry Reding
2017-10-17 12:13 ` Lothar Waßmann
2017-10-17 12:50 ` Thierry Reding
2017-10-11 11:23 ` [PATCH 2/9] drm/panel: simple: simplify display_mode definitions by using macro Lothar Waßmann
2017-10-17 12:09 ` Thierry Reding
2017-10-17 13:05 ` Lothar Waßmann
2017-10-17 13:08 ` Thierry Reding
2017-10-17 13:17 ` Lothar Waßmann
2017-10-11 11:23 ` [PATCH 3/9] drm/panel: simple: make it possible to override LCD bus format Lothar Waßmann
2017-10-13 22:13 ` Rob Herring
2017-10-17 12:12 ` Thierry Reding
2017-10-17 12:44 ` Lothar Waßmann
2017-10-17 12:56 ` Thierry Reding
2017-10-17 17:11 ` Rob Herring
2017-10-11 11:23 ` [PATCH 4/9] drm/panel: simple: add support for overriding the pixel clock polarity Lothar Waßmann
2017-10-16 22:13 ` Rob Herring
2017-10-17 6:51 ` Lothar Waßmann
2017-10-17 12:14 ` Thierry Reding
2017-10-17 12:25 ` Lothar Waßmann
2017-10-17 12:45 ` Thierry Reding
2017-10-25 9:56 ` Lothar Waßmann
2017-10-11 11:23 ` [PATCH 5/9] drm/panel: simple: add support for EDT ET0350 3.5" QVGA panel Lothar Waßmann
2017-10-17 19:50 ` Rob Herring
2017-10-11 11:23 ` [PATCH 6/9] drm/panel: simple: add support for EDT ET0430 4.3" HVGA panel Lothar Waßmann
2017-10-11 11:23 ` [PATCH 7/9] drm/panel: simple: add support for NLT NL12880 12.1" WXGA LVDS panel Lothar Waßmann
2017-10-11 11:23 ` [PATCH 8/9] drm/panel: simple: add support for EDT ETM0700G0EDH6 7" WVGA panel Lothar Waßmann
2017-10-11 11:23 ` [PATCH 9/9] drm/panel: simple: add support for EDT ET1010G0DSA/ETML1010G0DKA 10.1" WXGA LVDS panels Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507721021-28174-2-git-send-email-LW@KARO-electronics.de \
--to=lw@karo-electronics.de \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®