From: Rob Herring <robh@kernel.org>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: David Airlie <airlied@linux.ie>,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] drm/panel: simple: add support for EDT ET0350 3.5" QVGA panel
Date: Tue, 17 Oct 2017 14:50:38 -0500 [thread overview]
Message-ID: <20171017195038.glirxs3sixpcj7uj@rob-hp-laptop> (raw)
In-Reply-To: <1507721021-28174-6-git-send-email-LW@KARO-electronics.de>
On Wed, Oct 11, 2017 at 01:23:37PM +0200, Lothar Waßmann wrote:
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
> .../bindings/display/panel/edt,et0350g0dh6.txt | 7 +++++++
Please split bindings to separate patch.
> drivers/gpu/drm/panel/panel-simple.c | 19 +++++++++++++++++++
> 2 files changed, 26 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt b/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt
> new file mode 100644
> index 0000000..5546221
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/edt,et0350g0dh6.txt
> @@ -0,0 +1,7 @@
> +Emerging Display Technology Corp. 3.5" QVGA (320x240) TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "edt,et0350g0dh6"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
No reset lines, power supplies, etc.? Yes, simple-panel.txt defines
properties, but you still need to specify which ones you use. Otherwise,
I don't know if this panel has a single supply or you just forgot to
define the supplies.
Rob
next prev parent reply other threads:[~2017-10-17 19:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 11:23 [PATCH 0/9] drm/panel: simple: improve definition of display modes and add more panels Lothar Waßmann
2017-10-11 11:23 ` [PATCH 1/9] drm/panel: simple: add a macro for defining display modes in a simpler and less error prone way Lothar Waßmann
2017-10-17 12:08 ` Thierry Reding
2017-10-17 12:13 ` Lothar Waßmann
2017-10-17 12:50 ` Thierry Reding
2017-10-11 11:23 ` [PATCH 2/9] drm/panel: simple: simplify display_mode definitions by using macro Lothar Waßmann
2017-10-17 12:09 ` Thierry Reding
2017-10-17 13:05 ` Lothar Waßmann
2017-10-17 13:08 ` Thierry Reding
2017-10-17 13:17 ` Lothar Waßmann
2017-10-11 11:23 ` [PATCH 3/9] drm/panel: simple: make it possible to override LCD bus format Lothar Waßmann
2017-10-13 22:13 ` Rob Herring
2017-10-17 12:12 ` Thierry Reding
2017-10-17 12:44 ` Lothar Waßmann
2017-10-17 12:56 ` Thierry Reding
2017-10-17 17:11 ` Rob Herring
2017-10-11 11:23 ` [PATCH 4/9] drm/panel: simple: add support for overriding the pixel clock polarity Lothar Waßmann
2017-10-16 22:13 ` Rob Herring
2017-10-17 6:51 ` Lothar Waßmann
2017-10-17 12:14 ` Thierry Reding
2017-10-17 12:25 ` Lothar Waßmann
2017-10-17 12:45 ` Thierry Reding
2017-10-25 9:56 ` Lothar Waßmann
2017-10-11 11:23 ` [PATCH 5/9] drm/panel: simple: add support for EDT ET0350 3.5" QVGA panel Lothar Waßmann
2017-10-17 19:50 ` Rob Herring [this message]
2017-10-11 11:23 ` [PATCH 6/9] drm/panel: simple: add support for EDT ET0430 4.3" HVGA panel Lothar Waßmann
2017-10-11 11:23 ` [PATCH 7/9] drm/panel: simple: add support for NLT NL12880 12.1" WXGA LVDS panel Lothar Waßmann
2017-10-11 11:23 ` [PATCH 8/9] drm/panel: simple: add support for EDT ETM0700G0EDH6 7" WVGA panel Lothar Waßmann
2017-10-11 11:23 ` [PATCH 9/9] drm/panel: simple: add support for EDT ET1010G0DSA/ETML1010G0DKA 10.1" WXGA LVDS panels Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017195038.glirxs3sixpcj7uj@rob-hp-laptop \
--to=robh@kernel.org \
--cc=LW@KARO-electronics.de \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®