* [PATCH] selftests: add missing test result status in memory-hotplug test
@ 2017-10-17 7:06 lei.yang
2017-10-17 14:20 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: lei.yang @ 2017-10-17 7:06 UTC (permalink / raw)
To: lei.yang, linux-kernel, linux-kselftest, shuahkh
From: Lei Yang <Lei.Yang@windriver.com>
it only prints FAIL status when test fails, but doesn't print PASS
status when test pass,this patch is to add PASS status in the test log.
Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
---
tools/testing/selftests/memory-hotplug/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
index afb2624..61d9b04 100644
--- a/tools/testing/selftests/memory-hotplug/Makefile
+++ b/tools/testing/selftests/memory-hotplug/Makefile
@@ -3,10 +3,10 @@ all:
include ../lib.mk
TEST_PROGS := mem-on-off-test.sh
-override RUN_TESTS := ./mem-on-off-test.sh -r 2 || echo "selftests: memory-hotplug [FAIL]"
+override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
override EMIT_TESTS := echo "$(RUN_TESTS)"
run_full_test:
- @/bin/bash ./mem-on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
+ @/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]"
clean:
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: add missing test result status in memory-hotplug test
2017-10-17 7:06 [PATCH] selftests: add missing test result status in memory-hotplug test lei.yang
@ 2017-10-17 14:20 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2017-10-17 14:20 UTC (permalink / raw)
To: lei.yang, linux-kernel, linux-kselftest; +Cc: Shuah Khan, Shuah Khan
On 10/17/2017 01:06 AM, lei.yang@windriver.com wrote:
> From: Lei Yang <Lei.Yang@windriver.com>
>
> it only prints FAIL status when test fails, but doesn't print PASS
> status when test pass,this patch is to add PASS status in the test log.
>
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
> tools/testing/selftests/memory-hotplug/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
> index afb2624..61d9b04 100644
> --- a/tools/testing/selftests/memory-hotplug/Makefile
> +++ b/tools/testing/selftests/memory-hotplug/Makefile
> @@ -3,10 +3,10 @@ all:
> include ../lib.mk
>
> TEST_PROGS := mem-on-off-test.sh
> -override RUN_TESTS := ./mem-on-off-test.sh -r 2 || echo "selftests: memory-hotplug [FAIL]"
> +override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
> override EMIT_TESTS := echo "$(RUN_TESTS)"
>
> run_full_test:
> - @/bin/bash ./mem-on-off-test.sh || echo "memory-hotplug selftests: [FAIL]"
> + @/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]"
>
> clean:
>
Looks good to me. I will get this into 4.15-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-17 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 7:06 [PATCH] selftests: add missing test result status in memory-hotplug test lei.yang
2017-10-17 14:20 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®