From: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com,
Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Subject: [PATCH v3 2/2] extcon: add optional input-debounce attribute
Date: Thu, 19 Oct 2017 15:22:53 +0530 [thread overview]
Message-ID: <1508406773-887-2-git-send-email-raveendra.padasalagi@broadcom.com> (raw)
In-Reply-To: <1508406773-887-1-git-send-email-raveendra.padasalagi@broadcom.com>
Add changes to capture optional dt attribute "input-debounce"
provided in extcon node and used the same value if provided otherwise
default value of 20000 usecs is used for id and vbus gpios debounce time.
Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com>
---
Changes in v3:
- Changed USB_GPIO_DEBOUNCE_MS to USB_GPIO_DEBOUNCE_USEC
- Changed msecs_to_jiffies() to usecs_to_jiffies()
Changes in v2:
Rename gpio_debounce_timeout_ms to debounce_usecs
drivers/extcon/extcon-usb-gpio.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index 9c925b0..69149e2 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -28,7 +28,7 @@
#include <linux/workqueue.h>
#include <linux/pinctrl/consumer.h>
-#define USB_GPIO_DEBOUNCE_MS 20 /* ms */
+#define USB_GPIO_DEBOUNCE_USEC 20000 /* us */
struct usb_extcon_info {
struct device *dev;
@@ -41,6 +41,7 @@ struct usb_extcon_info {
unsigned long debounce_jiffies;
struct delayed_work wq_detcable;
+ unsigned int debounce_usecs;
};
static const unsigned int usb_extcon_cable[] = {
@@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev)
if (IS_ERR(info->vbus_gpiod))
return PTR_ERR(info->vbus_gpiod);
+ ret = of_property_read_u32(np, "input-debounce",
+ &info->debounce_usecs);
+ if (ret)
+ info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC;
+
info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable);
if (IS_ERR(info->edev)) {
dev_err(dev, "failed to allocate extcon device\n");
@@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev)
if (info->id_gpiod)
ret = gpiod_set_debounce(info->id_gpiod,
- USB_GPIO_DEBOUNCE_MS * 1000);
+ info->debounce_usecs);
if (!ret && info->vbus_gpiod)
ret = gpiod_set_debounce(info->vbus_gpiod,
- USB_GPIO_DEBOUNCE_MS * 1000);
+ info->debounce_usecs);
if (ret < 0)
- info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
+ info->debounce_jiffies = usecs_to_jiffies(info->debounce_usecs);
INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
--
1.9.1
next prev parent reply other threads:[~2017-10-19 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 9:52 [PATCH v3 1/2] Documentation: dt: " Raveendra Padasalagi
2017-10-19 9:52 ` Raveendra Padasalagi [this message]
2017-10-19 10:18 ` [PATCH v3 2/2] " Chanwoo Choi
2022-02-04 13:59 ` Francesco Dolcini
2022-02-18 9:56 ` Chanwoo Choi
2022-02-18 11:32 ` [PATCH v3 1/2] Documentation: dt: " Krzysztof Kozlowski
2022-02-18 11:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508406773-887-2-git-send-email-raveendra.padasalagi@broadcom.com \
--to=raveendra.padasalagi@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®