* [PATCH] selftests: add "PASS" status in log for mqueue
@ 2017-11-05 9:22 Lei Yang
2017-11-06 23:37 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Lei Yang @ 2017-11-05 9:22 UTC (permalink / raw)
To: lei.yang, shuahkh, linux-kselftest, linux-kernel
It prints 'FAIL' status when test failed, but not print
'PASS' when test passed.
Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
---
tools/testing/selftests/mqueue/Makefile | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile
index 0f5e347..437b048 100644
--- a/tools/testing/selftests/mqueue/Makefile
+++ b/tools/testing/selftests/mqueue/Makefile
@@ -5,12 +5,12 @@ TEST_GEN_PROGS := mq_open_tests mq_perf_tests
include ../lib.mk
override define RUN_TESTS
- $(OUTPUT)/mq_open_tests /test1 || echo "selftests: mq_open_tests [FAIL]"
- $(OUTPUT)//mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
+ $(OUTPUT)/mq_open_tests /test1 && echo "selftests: mq_open_tests [PASS]" || echo "selftests: mq_open_tests [FAIL]"
+ $(OUTPUT)/mq_perf_tests && echo "selftests: mq_perf_tests [PASS]" || echo "selftests: mq_perf_tests [FAIL]"
endef
override define EMIT_TESTS
- echo "./mq_open_tests /test1 || echo \"selftests: mq_open_tests [FAIL]\""
- echo "./mq_perf_tests || echo \"selftests: mq_perf_tests [FAIL]\""
+ echo "./mq_open_tests /test1 && echo \"selftests: mq_open_tests [PASS]\" || echo \"selftests: mq_open_tests [FAIL]\""
+ echo "./mq_perf_tests && echo \"selftests: mq_perf_tests [PASS]\" || echo \"selftests: mq_perf_tests [FAIL]\""
endef
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests: add "PASS" status in log for mqueue
2017-11-05 9:22 [PATCH] selftests: add "PASS" status in log for mqueue Lei Yang
@ 2017-11-06 23:37 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2017-11-06 23:37 UTC (permalink / raw)
To: Lei Yang; +Cc: linux-kselftest, linux-kernel, Shuah Khan, Shuah Khan
On 11/05/2017 02:22 AM, Lei Yang wrote:
> It prints 'FAIL' status when test failed, but not print
> 'PASS' when test passed.
>
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
> tools/testing/selftests/mqueue/Makefile | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile
> index 0f5e347..437b048 100644
> --- a/tools/testing/selftests/mqueue/Makefile
> +++ b/tools/testing/selftests/mqueue/Makefile
> @@ -5,12 +5,12 @@ TEST_GEN_PROGS := mq_open_tests mq_perf_tests
> include ../lib.mk
>
> override define RUN_TESTS
> - $(OUTPUT)/mq_open_tests /test1 || echo "selftests: mq_open_tests [FAIL]"
> - $(OUTPUT)//mq_perf_tests || echo "selftests: mq_perf_tests [FAIL]"
> + $(OUTPUT)/mq_open_tests /test1 && echo "selftests: mq_open_tests [PASS]" || echo "selftests: mq_open_tests [FAIL]"
> + $(OUTPUT)/mq_perf_tests && echo "selftests: mq_perf_tests [PASS]" || echo "selftests: mq_perf_tests [FAIL]"
> endef
>
> override define EMIT_TESTS
> - echo "./mq_open_tests /test1 || echo \"selftests: mq_open_tests [FAIL]\""
> - echo "./mq_perf_tests || echo \"selftests: mq_perf_tests [FAIL]\""
> + echo "./mq_open_tests /test1 && echo \"selftests: mq_open_tests [PASS]\" || echo \"selftests: mq_open_tests [FAIL]\""
> + echo "./mq_perf_tests && echo \"selftests: mq_perf_tests [PASS]\" || echo \"selftests: mq_perf_tests [FAIL]\""
> endef
>
>
Thanks for the patch. I plan to get this into 4.15-rc1
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-06 23:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-05 9:22 [PATCH] selftests: add "PASS" status in log for mqueue Lei Yang
2017-11-06 23:37 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®