* [PATCH 1/1] Use checkpatch.pl to make thinkpad_acpi.c error free: add parenthesis to complex macros
@ 2017-11-14 23:14 Simranjit Singh
2017-11-15 11:04 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Simranjit Singh @ 2017-11-14 23:14 UTC (permalink / raw)
To: ibm-acpi; +Cc: dvhart, andy, ibm-acpi-devel, platform-driver-x86, linux-kernel
From: Simranjit Singh <simranjit.singh@corebaby.org>
Added parentheses around complex macros following checkpatch.pl for thinkpad_acpi.c
Signed-off-by: Simranjit Singh
---
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 9ad1f5b..e2616c2 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -1650,23 +1650,23 @@ static void tpacpi_remove_driver_attributes(struct device_driver *drv)
TPV_Q(PCI_VENDOR_ID_IBM, __id1, __id2, __bv1, __bv2)
/* Outdated IBM BIOSes often lack the EC id string */
-#define TPV_QI1(__id1, __id2, __bv1, __bv2, __ev1, __ev2) \
+#define (TPV_QI1(__id1, __id2, __bv1, __bv2, __ev1, __ev2) \
TPV_Q_X(PCI_VENDOR_ID_IBM, __id1, __id2, \
__bv1, __bv2, TPID(__id1, __id2), \
__ev1, __ev2), \
TPV_Q_X(PCI_VENDOR_ID_IBM, __id1, __id2, \
__bv1, __bv2, TPACPI_MATCH_UNKNOWN, \
- __ev1, __ev2)
+ __ev1, __ev2))
/* Outdated IBM BIOSes often lack the EC id string */
-#define TPV_QI2(__bid1, __bid2, __bv1, __bv2, \
+#define (TPV_QI2(__bid1, __bid2, __bv1, __bv2, \
__eid1, __eid2, __ev1, __ev2) \
TPV_Q_X(PCI_VENDOR_ID_IBM, __bid1, __bid2, \
__bv1, __bv2, TPID(__eid1, __eid2), \
__ev1, __ev2), \
TPV_Q_X(PCI_VENDOR_ID_IBM, __bid1, __bid2, \
__bv1, __bv2, TPACPI_MATCH_UNKNOWN, \
- __ev1, __ev2)
+ __ev1, __ev2))
#define TPV_QL0(__id1, __id2, __bv1, __bv2) \
TPV_Q(PCI_VENDOR_ID_LENOVO, __id1, __id2, __bv1, __bv2)
@@ -6238,8 +6238,8 @@ static ssize_t thermal_temp_input_show(struct device *dev,
THERMAL_SENSOR_ATTR_TEMP(16, 15),
};
-#define THERMAL_ATTRS(X) \
- &sensor_dev_attr_thermal_temp_input[X].dev_attr.attr
+#define (THERMAL_ATTRS(X) \
+ &sensor_dev_attr_thermal_temp_input[X].dev_attr.attr)
static struct attribute *thermal_temp_input_attr[] = {
THERMAL_ATTRS(8),
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] Use checkpatch.pl to make thinkpad_acpi.c error free: add parenthesis to complex macros
2017-11-14 23:14 [PATCH 1/1] Use checkpatch.pl to make thinkpad_acpi.c error free: add parenthesis to complex macros Simranjit Singh
@ 2017-11-15 11:04 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2017-11-15 11:04 UTC (permalink / raw)
To: Simranjit Singh
Cc: Henrique de Moraes Holschuh, dvhart, Andy Shevchenko,
ibm-acpi-devel, Platform Driver, linux-kernel
On Wed, Nov 15, 2017 at 1:14 AM, Simranjit Singh
<simranjit.singh@corebaby.org> wrote:
> From: Simranjit Singh <simranjit.singh@corebaby.org>
>
> Added parentheses around complex macros following checkpatch.pl for thinkpad_acpi.c
Same story.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-15 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-14 23:14 [PATCH 1/1] Use checkpatch.pl to make thinkpad_acpi.c error free: add parenthesis to complex macros Simranjit Singh
2017-11-15 11:04 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®