From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Michal Marek <michal.lkml@markovi.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Song Liu <songliubraving@fb.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com,
trivial@kernel.org
Subject: Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c
Date: Thu, 16 Nov 2017 09:05:38 -0800 [thread overview]
Message-ID: <1510851938.31559.33.camel@perches.com> (raw)
In-Reply-To: <20171115215551.1afa1a8c@vmware.local.home>
On Wed, 2017-11-15 at 21:55 -0500, Steven Rostedt wrote:
> On Wed, 15 Nov 2017 14:55:19 -0800
> Joe Perches <joe@perches.com> wrote:
>
> > Maybe use the much more common below instead?
> >
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> Is there someplace this is documented. My git grep foo isn't finding it
> for me.
Not so far as I know.
Maybe Michal Marek or Masahiro Yamada might add some
documentation in the future about these KBUILD defines.
btw, there are about 1800 #define pr_fmt uses and most
of them use KBUILD_MODNAME
$ git grep -P "^\s*#\s*define\s+pr_fmt\b" | \
cut -f2- -d":" | \
sed -r 's/^\s*#\s*define\s+pr_fmt([^ ]+)\s++/#define pr_fmt\1 /' | \
sed -r 's/\)\s+/) /' | sort | uniq -c | sort -rn | head -10
1166 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
134 #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
32 #define pr_fmt(fmt) "%s: " fmt, __func__
22 #define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__
17 #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
13 #define pr_fmt(fmt) "xen:" KBUILD_MODNAME ": " fmt
11 #define pr_fmt(fmt) "arcnet:" KBUILD_MODNAME ": " fmt
10 #define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__
10 #define pr_fmt(fmt) "IPv6: " fmt
9 #define pr_fmt(fmt) fmt
next prev parent reply other threads:[~2017-11-16 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 22:02 Song Liu
2017-11-14 13:58 ` Masami Hiramatsu
2017-11-15 18:14 ` Steven Rostedt
2017-11-15 22:55 ` Joe Perches
2017-11-16 2:55 ` Steven Rostedt
2017-11-16 17:05 ` Joe Perches [this message]
2017-12-06 11:00 ` Masahiro Yamada
2017-11-16 13:21 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510851938.31559.33.camel@perches.com \
--to=joe@perches.com \
--cc=jikos@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=trivial@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®