From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Jiri Kosina <jikos@kernel.org>
Cc: Song Liu <songliubraving@fb.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com,
trivial@kernel.org
Subject: Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c
Date: Wed, 15 Nov 2017 14:55:19 -0800 [thread overview]
Message-ID: <1510786519.25299.7.camel@perches.com> (raw)
In-Reply-To: <20171115131410.13a5a4c8@vmware.local.home>
On Wed, 2017-11-15 at 13:14 -0500, Steven Rostedt wrote:
> On Tue, 14 Nov 2017 22:58:31 +0900 Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > On Mon, 13 Nov 2017 14:02:46 -0800 Song Liu <songliubraving@fb.com> wrote:
> > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of
> > > "trace_kprobe".
> > Oh, good catch!
> > Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> Thanks.
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Jiri, can you take this in your tree?
>
[]
> > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
[]
> > > @@ -17,7 +17,7 @@
> > > * Copyright (C) IBM Corporation, 2010-2012
> > > * Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> > > */
> > > -#define pr_fmt(fmt) "trace_kprobe: " fmt
> > > +#define pr_fmt(fmt) "trace_uprobe: " fmt
Maybe use the much more common below instead?
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
next prev parent reply other threads:[~2017-11-15 22:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 22:02 Song Liu
2017-11-14 13:58 ` Masami Hiramatsu
2017-11-15 18:14 ` Steven Rostedt
2017-11-15 22:55 ` Joe Perches [this message]
2017-11-16 2:55 ` Steven Rostedt
2017-11-16 17:05 ` Joe Perches
2017-12-06 11:00 ` Masahiro Yamada
2017-11-16 13:21 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510786519.25299.7.camel@perches.com \
--to=joe@perches.com \
--cc=jikos@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome