From: Joe Perches <joe@perches.com>
To: Axel Lin <axel.lin@ingics.com>, Keerthy <j-keerthy@ti.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] regulator: tps65218: Add NULL test for devm_kzalloc call
Date: Thu, 16 Nov 2017 20:11:22 -0800 [thread overview]
Message-ID: <1510891882.28769.1.camel@perches.com> (raw)
In-Reply-To: <CAFRkauCOcz8JZMvXWqB3t9_Kewm3XqQgeQLti1BBaAVwQ8PREg@mail.gmail.com>
On Fri, 2017-11-17 at 11:58 +0800, Axel Lin wrote:
> 2017-11-16 19:23 GMT+08:00 Keerthy <j-keerthy@ti.com>:
> >
> >
> > On Monday 13 November 2017 06:22 PM, Axel Lin wrote:
> > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >
> > One line commit message would be better than blank commit message.
>
> It's just too trivial and checkpatch does not complain.
I think trivial commits don't need commit messages
if the subject line is sufficiently descriptive.
next prev parent reply other threads:[~2017-11-17 4:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 12:52 Axel Lin
2017-11-16 11:23 ` Keerthy
2017-11-17 3:58 ` Axel Lin
2017-11-17 4:11 ` Joe Perches [this message]
2017-11-16 19:29 ` Applied "regulator: tps65218: Add NULL test for devm_kzalloc call" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510891882.28769.1.camel@perches.com \
--to=joe@perches.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome