From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: eni: fix several indentation issues
Date: Mon, 27 Nov 2017 21:54:27 -0800 [thread overview]
Message-ID: <1511848467.32426.100.camel@perches.com> (raw)
In-Reply-To: <20171127131510.10500-1-colin.king@canonical.com>
On Mon, 2017-11-27 at 13:15 +0000, Colin King wrote:
> drivers/atm/eni.c
Aren't all those ++ variables unused?
They seem to be emitted in an
#if 0
printk(...)
#endif
Maybe these should be removed or changed
to something like:
#if 0
#define DEBUG_INCR(var) do { (var)++ } while (0)
#else
#define DEBUG_INCR(var) do {} while (0)
#endif
...
DEBUG_INCR(rx_enqueued);
next prev parent reply other threads:[~2017-11-28 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 13:15 Colin King
2017-11-28 5:54 ` Joe Perches [this message]
2017-11-30 14:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511848467.32426.100.camel@perches.com \
--to=joe@perches.com \
--cc=3chas3@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®