From: kan.liang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Cc: jolsa@kernel.org, wangnan0@huawei.com, namhyung@kernel.org,
ak@linux.intel.com, Kan Liang <kan.liang@intel.com>
Subject: [PATCH 0/5] perf top overwrite mode
Date: Tue, 5 Dec 2017 14:39:10 -0800 [thread overview]
Message-ID: <1512513555-118798-1-git-send-email-kan.liang@intel.com> (raw)
From: Kan Liang <kan.liang@intel.com>
perf_top__mmap_read has severe performance issue in
Knights Landing/Mill, when monitoring in heavy load system. It costs
several minutes to finish, which is unacceptable.
Currently, perf top is non overwrite mode. For non overwrite mode, it
tries to read everything in the ringbuffer and doesn't pause the
ringbuffer. Once there are lots of samples delivered persistently,
the processing time could be very long. Also, the latest samples could
be lost when the ringbuffer is full.
It's better to change it to overwrite mode, which takes a snapshot for
the system by pausing the ringbuffer and could significantly reducing
the processing time (from several minutes to several seconds).
Also, the overwrite mode always keep the latest samples.
Patch 1-3: Modify perf_mmap__read_catchup and perf_mmap__read_backward.
Make them ready for overwrite mode
Patch 4: Swith perf top to overwrite mode
Patch 5: The latency could be still higher than refresh time in some
extreme cases. Give user some hints to reduce the latency.
Kan Liang (5):
perf tools: remove stale perf evlist mmap read for backward
perf tools: rewrite perf mmap read for overwrite
perf tools: reuse perf_mmap__read_catchup in perf_mmap__push
perf top: switch to overwrite mode
perf top: check the latency of perf_top__mmap_read
tools/perf/builtin-top.c | 40 ++++++-----
tools/perf/tests/backward-ring-buffer.c | 9 ++-
tools/perf/ui/browsers/hists.c | 12 +++-
tools/perf/util/evlist.c | 17 -----
tools/perf/util/evlist.h | 4 --
tools/perf/util/mmap.c | 119 +++++++++++++++-----------------
tools/perf/util/mmap.h | 7 +-
7 files changed, 102 insertions(+), 106 deletions(-)
--
2.5.5
next reply other threads:[~2017-12-05 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 22:39 kan.liang [this message]
2017-12-05 22:39 ` [PATCH 1/5] perf tools: remove stale perf evlist mmap read for backward kan.liang
2017-12-05 22:39 ` [PATCH 2/5] perf tools: rewrite perf mmap read for overwrite kan.liang
2017-12-05 22:39 ` [PATCH 3/5] perf tools: reuse perf_mmap__read_catchup in perf_mmap__push kan.liang
2017-12-05 22:39 ` [PATCH 4/5] perf top: switch to overwrite mode kan.liang
2017-12-06 1:58 ` Wangnan (F)
2017-12-05 22:39 ` [PATCH 5/5] perf top: check the latency of perf_top__mmap_read kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512513555-118798-1-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®