From: kan.liang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Cc: jolsa@kernel.org, wangnan0@huawei.com, namhyung@kernel.org,
ak@linux.intel.com, Kan Liang <kan.liang@intel.com>
Subject: [PATCH 5/5] perf top: check the latency of perf_top__mmap_read
Date: Tue, 5 Dec 2017 14:39:15 -0800 [thread overview]
Message-ID: <1512513555-118798-6-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1512513555-118798-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
The latency of perf_top__mmap_read should be lower than refresh time.
If not, give some hints to reduce the latency.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
tools/perf/builtin-top.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 721d786..f36936c 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -872,13 +872,23 @@ static void perf_top__mmap_read_idx(struct perf_top *top, int idx)
static void perf_top__mmap_read(struct perf_top *top)
{
+ unsigned long long start, end;
int i;
+ start = rdclock();
perf_evlist__toggle_bkw_mmap(top->evlist, BKW_MMAP_DATA_PENDING);
for (i = 0; i < top->evlist->nr_mmaps; i++)
perf_top__mmap_read_idx(top, i);
perf_evlist__toggle_bkw_mmap(top->evlist, BKW_MMAP_EMPTY);
perf_evlist__toggle_bkw_mmap(top->evlist, BKW_MMAP_RUNNING);
+ end = rdclock();
+
+ if ((end - start) > (unsigned long long)top->delay_secs * NSEC_PER_SEC)
+ ui__warning("Too slow to read ring buffer.\n"
+ "Please try increasing the period (-c) or\n"
+ "decreasing the freq (-F) or\n"
+ "limiting the number of CPUs (-C)\n");
+
}
static int perf_top__start_counters(struct perf_top *top)
--
2.5.5
prev parent reply other threads:[~2017-12-05 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 22:39 [PATCH 0/5] perf top overwrite mode kan.liang
2017-12-05 22:39 ` [PATCH 1/5] perf tools: remove stale perf evlist mmap read for backward kan.liang
2017-12-05 22:39 ` [PATCH 2/5] perf tools: rewrite perf mmap read for overwrite kan.liang
2017-12-05 22:39 ` [PATCH 3/5] perf tools: reuse perf_mmap__read_catchup in perf_mmap__push kan.liang
2017-12-05 22:39 ` [PATCH 4/5] perf top: switch to overwrite mode kan.liang
2017-12-06 1:58 ` Wangnan (F)
2017-12-05 22:39 ` kan.liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512513555-118798-6-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®