mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kan.liang@intel.com
To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Cc: wangnan0@huawei.com, jolsa@kernel.org, namhyung@kernel.org,
	ak@linux.intel.com, yao.jin@linux.intel.com,
	Kan Liang <kan.liang@intel.com>
Subject: [PATCH V3 01/12] perf evlist: remove stale mmap read for backward
Date: Thu, 21 Dec 2017 10:08:43 -0800	[thread overview]
Message-ID: <1513879734-237492-2-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1513879734-237492-1-git-send-email-kan.liang@intel.com>

From: Kan Liang <kan.liang@intel.com>

perf_evlist__mmap_read_catchup and perf_evlist__mmap_read_backward are
only for overwrite mode.
But they read the evlist->mmap buffer which is for non-overwrite mode.

It did not bring any serious problem yet, because there is no one use
it.

Remove the unused interfaces.

Acked-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
 tools/perf/util/evlist.c | 17 -----------------
 tools/perf/util/evlist.h |  4 ----
 2 files changed, 21 deletions(-)

diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index f0a5e09..cf0fd35 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -714,28 +714,11 @@ union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int
 	return perf_mmap__read_forward(md);
 }
 
-union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)
-{
-	struct perf_mmap *md = &evlist->mmap[idx];
-
-	/*
-	 * No need to check messup for backward ring buffer:
-	 * We can always read arbitrary long data from a backward
-	 * ring buffer unless we forget to pause it before reading.
-	 */
-	return perf_mmap__read_backward(md);
-}
-
 union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx)
 {
 	return perf_evlist__mmap_read_forward(evlist, idx);
 }
 
-void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx)
-{
-	perf_mmap__read_catchup(&evlist->mmap[idx]);
-}
-
 void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx)
 {
 	perf_mmap__consume(&evlist->mmap[idx], false);
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
index 7516066..a80fd47 100644
--- a/tools/perf/util/evlist.h
+++ b/tools/perf/util/evlist.h
@@ -132,10 +132,6 @@ union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx);
 
 union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist,
 						 int idx);
-union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist,
-						  int idx);
-void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx);
-
 void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx);
 
 int perf_evlist__open(struct perf_evlist *evlist);
-- 
2.5.5

  reply	other threads:[~2017-12-21 18:10 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 18:08 [PATCH V3 00/12] perf top overwrite mode kan.liang
2017-12-21 18:08 ` kan.liang [this message]
2017-12-21 18:08 ` [PATCH V3 02/12] perf mmap: factor out function to find ringbuffer position kan.liang
2018-01-10 15:37   ` Jiri Olsa
2018-01-10 19:31     ` Liang, Kan
2018-01-11 14:25   ` Jiri Olsa
2018-01-11 21:26     ` Liang, Kan
2018-01-12 10:52       ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 03/12] perf mmap: discard 'prev' in perf_mmap__read kan.liang
2018-01-11 14:25   ` Jiri Olsa
2018-01-11 21:27     ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 04/12] perf mmap: introduce perf_mmap__read_done kan.liang
2018-01-02  7:33   ` Namhyung Kim
2018-01-03 14:15     ` Liang, Kan
2018-01-04  2:46       ` Namhyung Kim
2018-01-04 14:00         ` Liang, Kan
2018-01-09  7:12           ` Namhyung Kim
2018-01-09 15:12             ` Liang, Kan
2018-01-11 12:00               ` Namhyung Kim
2018-01-11 14:40                 ` Liang, Kan
2018-01-11 14:25   ` Jiri Olsa
2018-01-11 21:27     ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 05/12] perf mmap: introduce perf_mmap__read_event kan.liang
2017-12-21 18:08 ` [PATCH V3 06/12] perf test: update mmap read functions for backward-ring-buffer test kan.liang
2017-12-21 18:08 ` [PATCH V3 07/12] perf mmap: discard legacy interface for mmap read kan.liang
2018-01-11 14:25   ` Jiri Olsa
2018-01-11 21:28     ` Liang, Kan
2018-01-12 10:52       ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 08/12] perf top: check per event overwrite term kan.liang
2018-01-11 14:25   ` Jiri Olsa
2018-01-11 21:29     ` Liang, Kan
2018-01-12 11:42       ` Jiri Olsa
2018-01-12 14:58         ` Liang, Kan
2018-01-12 16:46         ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 09/12] perf evsel: expose perf_missing_features.write_backward kan.liang
2017-12-21 18:08 ` [PATCH V3 10/12] perf top: add overwrite fall back kan.liang
2018-01-11 14:26   ` Jiri Olsa
2018-01-11 21:30     ` Liang, Kan
2018-01-12 11:42       ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 11/12] perf top: switch default mode to overwrite mode kan.liang
2018-01-11 14:26   ` Jiri Olsa
2018-01-11 21:30     ` Liang, Kan
2018-01-11 21:30     ` Liang, Kan
2018-01-11 14:26   ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 12/12] perf top: check the latency of perf_top__mmap_read kan.liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513879734-237492-2-git-send-email-kan.liang@intel.com \
    --to=kan.liang@intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=wangnan0@huawei.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome