From: "Liang, Kan" <kan.liang@intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "acme@kernel.org" <acme@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wangnan0@huawei.com" <wangnan0@huawei.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"yao.jin@linux.intel.com" <yao.jin@linux.intel.com>
Subject: RE: [PATCH V3 10/12] perf top: add overwrite fall back
Date: Thu, 11 Jan 2018 21:30:20 +0000 [thread overview]
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077537FFC30@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180111142626.GH16655@krava>
> On Thu, Dec 21, 2017 at 10:08:52AM -0800, kan.liang@intel.com wrote:
> > From: Kan Liang <kan.liang@intel.com>
> >
> > Switch to non-overwrite mode if kernel doesnot support overwrite
> > ringbuffer.
> >
> > It's only effect when overwrite mode is supported.
> > No change to current behavior.
> >
> > Signed-off-by: Kan Liang <kan.liang@intel.com>
> > ---
> > tools/perf/builtin-top.c | 36 ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 36 insertions(+)
> >
> > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> > index 4b85e7b..8d19ef7 100644
> > --- a/tools/perf/builtin-top.c
> > +++ b/tools/perf/builtin-top.c
> > @@ -931,6 +931,27 @@ static int perf_top_overwrite_check(struct
> perf_top *top)
> > return 0;
> > }
> >
> > +static int perf_top_overwrite_fallback(struct perf_top *top,
> > + struct perf_evsel *evsel)
> > +{
> > + struct record_opts *opts = &top->record_opts;
> > + struct perf_evlist *evlist = top->evlist;
> > + struct perf_evsel *counter;
> > +
> > + if (!opts->overwrite)
> > + return 0;
> > +
> > + /* only fall back when first event fails */
> > + if (evsel != perf_evlist__first(evlist))
> > + return 0;
> > +
> > + evlist__for_each_entry(evlist, counter)
> > + counter->attr.write_backward = false;
> > + opts->overwrite = false;
> > + ui__warning("fall back to non-overwrite mode\n");
> > + return 1;
> > +}
>
> we already do that for evsel in perf_evsel__open.. could we make
> this fallback on one place only?
>
> checking the code, why don't we follow the
> perf_missing_features.write_backward
> like we do for other features in the perf_evsel__open and set
> write_backward accordingly, like in attached patch.
>
No, the per-event fallback is explicitly disabled in perf_evsel__open.
You may refer to commit 32a951b4fd6b ("perf evlist: Drop redundant
evsel->overwrite indicator)".
Now, only perf top supports the whole fallback. So it is specially handled.
Thanks,
Kan
> jirka
>
>
> ---
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index dbd80268de54..89253f4ff9ee 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1683,9 +1683,6 @@ int perf_evsel__open(struct perf_evsel *evsel,
> struct cpu_map *cpus,
> int pid = -1, err;
> enum { NO_CHANGE, SET_TO_MAX, INCREASED_MAX } set_rlimit =
> NO_CHANGE;
>
> - if (perf_missing_features.write_backward && evsel-
> >attr.write_backward)
> - return -EINVAL;
> -
> if (cpus == NULL) {
> static struct cpu_map *empty_cpu_map;
>
> @@ -1725,6 +1722,8 @@ int perf_evsel__open(struct perf_evsel *evsel,
> struct cpu_map *cpus,
> }
>
> fallback_missing_features:
> + if (perf_missing_features.write_backward)
> + evsel->attr.write_backward = false;
> if (perf_missing_features.clockid_wrong)
> evsel->attr.clockid = CLOCK_MONOTONIC; /* should always
> work */
> if (perf_missing_features.clockid) {
next prev parent reply other threads:[~2018-01-11 21:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 18:08 [PATCH V3 00/12] perf top overwrite mode kan.liang
2017-12-21 18:08 ` [PATCH V3 01/12] perf evlist: remove stale mmap read for backward kan.liang
2017-12-21 18:08 ` [PATCH V3 02/12] perf mmap: factor out function to find ringbuffer position kan.liang
2018-01-10 15:37 ` Jiri Olsa
2018-01-10 19:31 ` Liang, Kan
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:26 ` Liang, Kan
2018-01-12 10:52 ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 03/12] perf mmap: discard 'prev' in perf_mmap__read kan.liang
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:27 ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 04/12] perf mmap: introduce perf_mmap__read_done kan.liang
2018-01-02 7:33 ` Namhyung Kim
2018-01-03 14:15 ` Liang, Kan
2018-01-04 2:46 ` Namhyung Kim
2018-01-04 14:00 ` Liang, Kan
2018-01-09 7:12 ` Namhyung Kim
2018-01-09 15:12 ` Liang, Kan
2018-01-11 12:00 ` Namhyung Kim
2018-01-11 14:40 ` Liang, Kan
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:27 ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 05/12] perf mmap: introduce perf_mmap__read_event kan.liang
2017-12-21 18:08 ` [PATCH V3 06/12] perf test: update mmap read functions for backward-ring-buffer test kan.liang
2017-12-21 18:08 ` [PATCH V3 07/12] perf mmap: discard legacy interface for mmap read kan.liang
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:28 ` Liang, Kan
2018-01-12 10:52 ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 08/12] perf top: check per event overwrite term kan.liang
2018-01-11 14:25 ` Jiri Olsa
2018-01-11 21:29 ` Liang, Kan
2018-01-12 11:42 ` Jiri Olsa
2018-01-12 14:58 ` Liang, Kan
2018-01-12 16:46 ` Liang, Kan
2017-12-21 18:08 ` [PATCH V3 09/12] perf evsel: expose perf_missing_features.write_backward kan.liang
2017-12-21 18:08 ` [PATCH V3 10/12] perf top: add overwrite fall back kan.liang
2018-01-11 14:26 ` Jiri Olsa
2018-01-11 21:30 ` Liang, Kan [this message]
2018-01-12 11:42 ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 11/12] perf top: switch default mode to overwrite mode kan.liang
2018-01-11 14:26 ` Jiri Olsa
2018-01-11 21:30 ` Liang, Kan
2018-01-11 21:30 ` Liang, Kan
2018-01-11 14:26 ` Jiri Olsa
2017-12-21 18:08 ` [PATCH V3 12/12] perf top: check the latency of perf_top__mmap_read kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37D7C6CF3E00A74B8858931C1DB2F077537FFC30@SHSMSX103.ccr.corp.intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®