From: Lucas Stach <l.stach@pengutronix.de>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
David Airlie <airlied@linux.ie>
Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: Re: [PATCH] drm/etnaviv: fix '%x' warning
Date: Wed, 24 Jan 2018 12:57:06 +0100 [thread overview]
Message-ID: <1516795026.6411.7.camel@pengutronix.de> (raw)
In-Reply-To: <20180123170753.GA26470@embeddedgus>
Hi Gustavo,
Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:
> Fix the following warning by using %zx instead of %x for variable of
> type size_t:
>
> warning: format ‘%x’ expects argument of type ‘unsigned int’, but
> argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>
> Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks for the patch, but I already have an equivalent change queued up.
Regards,
Lucas
> ---
> This code was compiled with GCC 7.2.0
>
> drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> index d113fe0..49e0497 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> @@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
> > size_t pgsize = SZ_4K;
>
> > if (!IS_ALIGNED(iova | size, pgsize)) {
> > - pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
> > + pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
> > iova, size, pgsize);
> > return;
> > }
> @@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
> > int ret = 0;
>
> > if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
> > - pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
> > + pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
> > iova, &paddr, size, pgsize);
> > return -EINVAL;
> > }
next prev parent reply other threads:[~2018-01-24 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 17:07 Gustavo A. R. Silva
2018-01-24 11:57 ` Lucas Stach [this message]
2018-01-24 19:39 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516795026.6411.7.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=airlied@linux.ie \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=garsilva@embeddedor.com \
--cc=gustavo@embeddedor.com \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®