From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Wang, Haiyue" <haiyue.wang@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: joel@jms.id.au, arnd@arndb.de, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI
Date: Thu, 25 Jan 2018 14:23:10 +0200 [thread overview]
Message-ID: <1516882990.7000.1250.camel@linux.intel.com> (raw)
In-Reply-To: <b1584518-2938-7faa-cd83-d0245d1ba88f@linux.intel.com>
On Thu, 2018-01-25 at 10:29 +0800, Wang, Haiyue wrote:
>
> On 2018-01-23 16:44, Greg KH wrote:
> > On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote:
> > > + depends on ARCH_ASPEED || COMPILE_TEST
> > > + select REGMAP_MMIO
> >
> > Select or depend?
>
> Before, I used "depends on". I was told to to change "select". I'm
> not
> sure which is more better by practice ?
git grep will answer to this question, but also documentation is good to
read.
REGMAP API is selected by users.
One case where it's not so looks like a bug.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2018-01-25 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 11:52 Haiyue Wang
2018-01-23 8:44 ` Greg KH
2018-01-25 2:29 ` Wang, Haiyue
2018-01-25 12:23 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516882990.7000.1250.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=haiyue.wang@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome