* [PATCH] staging: auxdisplay: add missing MODULE_LICENSE()
@ 2018-01-31 9:31 Shannon Booth
2018-02-23 10:30 ` Miguel Ojeda
0 siblings, 1 reply; 2+ messages in thread
From: Shannon Booth @ 2018-01-31 9:31 UTC (permalink / raw)
To: paul.burton; +Cc: linux-kernel, Shannon Booth
This patch fixes the compilation warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o
Signed-off-by: Shannon Booth <shannon.ml.booth@gmail.com>
---
drivers/auxdisplay/img-ascii-lcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
index db040b3..9222c88 100644
--- a/drivers/auxdisplay/img-ascii-lcd.c
+++ b/drivers/auxdisplay/img-ascii-lcd.c
@@ -441,3 +441,5 @@ static struct platform_driver img_ascii_lcd_driver = {
.remove = img_ascii_lcd_remove,
};
module_platform_driver(img_ascii_lcd_driver);
+
+MODULE_LICENSE("GPL v2");
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: auxdisplay: add missing MODULE_LICENSE()
2018-01-31 9:31 [PATCH] staging: auxdisplay: add missing MODULE_LICENSE() Shannon Booth
@ 2018-02-23 10:30 ` Miguel Ojeda
0 siblings, 0 replies; 2+ messages in thread
From: Miguel Ojeda @ 2018-02-23 10:30 UTC (permalink / raw)
To: Shannon Booth; +Cc: Paul Burton, linux-kernel
Hi Shannon,
On Wed, Jan 31, 2018 at 10:31 AM, Shannon Booth
<shannon.ml.booth@gmail.com> wrote:
> This patch fixes the compilation warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/auxdisplay/img-ascii-lcd.o
>
> Signed-off-by: Shannon Booth <shannon.ml.booth@gmail.com>
> ---
> drivers/auxdisplay/img-ascii-lcd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
> index db040b3..9222c88 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -441,3 +441,5 @@ static struct platform_driver img_ascii_lcd_driver = {
> .remove = img_ascii_lcd_remove,
> };
> module_platform_driver(img_ascii_lcd_driver);
> +
> +MODULE_LICENSE("GPL v2");
This was already done by 09c479f7f1fbfaf848e5813996793966cd50be81
("auxdisplay: img-ascii-lcd: add missing
MODULE_DESCRIPTION/AUTHOR/LICENSE") back in early January.
In any case, it should have been "GPL" (i.e. version 2 or later), not
"GPL v2", according to the header in img-ascii-lcd.c, see:
https://elixir.bootlin.com/linux/v4.16-rc2/source/include/linux/module.h#L171
But thank you for the patch! :-)
Cheers,
Miguel
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-23 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 9:31 [PATCH] staging: auxdisplay: add missing MODULE_LICENSE() Shannon Booth
2018-02-23 10:30 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®