mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhang warden <zhangwarden@gmail.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Miroslav Benes <mbenes@suse.cz>, Jiri Kosina <jikos@kernel.org>,
	Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	live-patching@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] livepatch: Add using attribute to klp_func for using function show
Date: Wed, 4 Sep 2024 15:30:22 +0800	[thread overview]
Message-ID: <1517E547-55C1-4962-9B6F-D9723FEC2BE0@gmail.com> (raw)
In-Reply-To: <20240904071424.lmonwdbq5clw7kb7@treble>



> On Sep 4, 2024, at 15:14, Josh Poimboeuf <jpoimboe@kernel.org> wrote:
> 
> On Wed, Sep 04, 2024 at 02:34:44PM +0800, zhang warden wrote:
>> In the scenario where multiple people work together to maintain the
>> same system, or a long time running system, the patch sets will
>> inevitably be cumulative. I think kernel can maintain and tell user
>> this most accurate information by one sysfs interface.
> 
> If there are multiple people applying patches independently from each
> other (to the same function even!), you are playing with fire, as there
> could easily be implicit dependencies and conflicts between the patches.
> 
> 
Yep, I agree with you. This is not a good practice.

But we can work further, livepatch can tell which function is now running. This feature can do more than that.

Afterall, users alway want to know if their newly patched function successfully enabled and using to fix the bug-existed kernel function.

With this feature, user can confirm their patch is successfully running instead of using crash to look into /proc/kcore to make sure this function is running now. (I always use this method to check my function patched ... lol).

And I think further, if we use kpatch-build[1], `kpatch list` can not only tell us which patch is enabled, but also tell us the relationship between running function and patched module.
I think this is an exciting feature...

[1] https://github.com/dynup/kpatch.git


  reply	other threads:[~2024-09-04  7:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28  2:23 [PATCH v4 0/2] livepatch: Add using attribute to klp_func for using function Wardenjohn
2024-08-28  2:23 ` [PATCH v4 1/2] Introduce klp_ops into klp_func structure Wardenjohn
2024-09-05 10:10   ` Miroslav Benes
2024-09-05 14:33     ` zhang warden
2024-09-06  7:03       ` Miroslav Benes
2024-09-06  9:44         ` zhang warden
2024-09-13  9:46           ` zhang warden
2024-08-28  2:23 ` [PATCH v4 2/2] livepatch: Add using attribute to klp_func for using function show Wardenjohn
2024-09-04  1:54   ` zhang warden
2024-09-04  4:48   ` Josh Poimboeuf
2024-09-04  6:34     ` zhang warden
2024-09-04  7:14       ` Josh Poimboeuf
2024-09-04  7:30         ` zhang warden [this message]
2024-09-04 18:06           ` Josh Poimboeuf
2024-09-05 14:03             ` zhang warden
2024-09-05 16:30               ` Josh Poimboeuf
2024-09-05 10:23   ` Miroslav Benes
2024-09-05 14:17     ` zhang warden
2024-09-05 16:34     ` Josh Poimboeuf
2024-09-06  6:55       ` Miroslav Benes
2024-09-06  9:39       ` zhang warden
2024-09-06 16:39         ` Petr Mladek
2024-09-08  2:31           ` zhang warden
2024-09-06 16:13     ` Petr Mladek
2024-09-08  2:51       ` zhang warden
2024-09-10  8:01         ` Petr Mladek
2024-09-10  8:09           ` zhang warden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517E547-55C1-4962-9B6F-D9723FEC2BE0@gmail.com \
    --to=zhangwarden@gmail.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®