* [PATCH] media: i2c: adv748x: Fix cleanup jump on chip identification
@ 2018-02-07 21:11 Kieran Bingham
2018-02-09 15:34 ` Niklas Söderlund
0 siblings, 1 reply; 2+ messages in thread
From: Kieran Bingham @ 2018-02-07 21:11 UTC (permalink / raw)
To: Kieran Bingham, linux-renesas-soc, linux-media
Cc: Kieran Bingham, Mauro Carvalho Chehab, open list
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
The error handling for the adv748x_identify_chip() call erroneously
jumps to the err_cleanup_clients label before the clients have been
established.
Correct this by jumping to the next (and correct) label in the cleanup
code: err_cleanup_dt.
Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
drivers/media/i2c/adv748x/adv748x-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
index 6d62b817ed00..6ccaad7e9eca 100644
--- a/drivers/media/i2c/adv748x/adv748x-core.c
+++ b/drivers/media/i2c/adv748x/adv748x-core.c
@@ -651,7 +651,7 @@ static int adv748x_probe(struct i2c_client *client,
ret = adv748x_identify_chip(state);
if (ret) {
adv_err(state, "Failed to identify chip");
- goto err_cleanup_clients;
+ goto err_cleanup_dt;
}
/* Configure remaining pages as I2C clients with regmap access */
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: adv748x: Fix cleanup jump on chip identification
2018-02-07 21:11 [PATCH] media: i2c: adv748x: Fix cleanup jump on chip identification Kieran Bingham
@ 2018-02-09 15:34 ` Niklas Söderlund
0 siblings, 0 replies; 2+ messages in thread
From: Niklas Söderlund @ 2018-02-09 15:34 UTC (permalink / raw)
To: Kieran Bingham
Cc: Kieran Bingham, linux-renesas-soc, linux-media, Kieran Bingham,
Mauro Carvalho Chehab, open list
Hi Kieran,
Thanks for your patch.
On 2018-02-07 21:11:35 +0000, Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> The error handling for the adv748x_identify_chip() call erroneously
> jumps to the err_cleanup_clients label before the clients have been
> established.
>
> Correct this by jumping to the next (and correct) label in the cleanup
> code: err_cleanup_dt.
>
> Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
> index 6d62b817ed00..6ccaad7e9eca 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -651,7 +651,7 @@ static int adv748x_probe(struct i2c_client *client,
> ret = adv748x_identify_chip(state);
> if (ret) {
> adv_err(state, "Failed to identify chip");
> - goto err_cleanup_clients;
> + goto err_cleanup_dt;
> }
>
> /* Configure remaining pages as I2C clients with regmap access */
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-09 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-07 21:11 [PATCH] media: i2c: adv748x: Fix cleanup jump on chip identification Kieran Bingham
2018-02-09 15:34 ` Niklas Söderlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®