* [RESEND PATCH v2] checkpatch: add Crypto ON_STACK to declaration_macros
@ 2018-02-18 8:13 Gilad Ben-Yossef
2018-02-18 17:25 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Gilad Ben-Yossef @ 2018-02-18 8:13 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches; +Cc: Ofir Drang, linux-kernel
Add the crypto API *_ON_STACK to $declaration_macros.
Resolves the following false warning:
WARNING: Missing a blank line after declarations
+ int err;
+ SHASH_DESC_ON_STACK(desc, ctx_p->shash_tfm);
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3d40403..7d632645 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -791,7 +791,8 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};
our $declaration_macros = qr{(?x:
(?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
(?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(|
- (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
+ (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(|
+ (?:SKCIPHER_REQUEST|SHASH_DESC|AHASH_REQUEST)_ON_STACK\s*\(
)};
sub deparenthesize {
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH v2] checkpatch: add Crypto ON_STACK to declaration_macros
2018-02-18 8:13 [RESEND PATCH v2] checkpatch: add Crypto ON_STACK to declaration_macros Gilad Ben-Yossef
@ 2018-02-18 17:25 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2018-02-18 17:25 UTC (permalink / raw)
To: Gilad Ben-Yossef, Andy Whitcroft, Andrew Morton; +Cc: Ofir Drang, linux-kernel
On Sun, 2018-02-18 at 08:13 +0000, Gilad Ben-Yossef wrote:
> Add the crypto API *_ON_STACK to $declaration_macros.
>
> Resolves the following false warning:
>
> WARNING: Missing a blank line after declarations
> + int err;
> + SHASH_DESC_ON_STACK(desc, ctx_p->shash_tfm);
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3d40403..7d632645 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -791,7 +791,8 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};
> our $declaration_macros = qr{(?x:
> (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
> (?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(|
> - (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
> + (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(|
> + (?:SKCIPHER_REQUEST|SHASH_DESC|AHASH_REQUEST)_ON_STACK\s*\(
> )};
>
> sub deparenthesize {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-18 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-18 8:13 [RESEND PATCH v2] checkpatch: add Crypto ON_STACK to declaration_macros Gilad Ben-Yossef
2018-02-18 17:25 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome