From: "Daniel Díaz" <daniel.diaz@linaro.org>
To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org
Cc: "Daniel Díaz" <daniel.diaz@linaro.org>,
"Bamvor Jian Zhang" <bamvor.zhangjian@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Shuah Khan" <shuah@kernel.org>,
linux-gpio@vger.kernel.org (open list:GPIO MOCKUP DRIVER),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/2] selftests/gpio: Fix OUTPUT directory in Makefile
Date: Wed, 21 Feb 2018 15:52:44 -0600 [thread overview]
Message-ID: <1519249964-1630-2-git-send-email-daniel.diaz@linaro.org> (raw)
In-Reply-To: <1519249964-1630-1-git-send-email-daniel.diaz@linaro.org>
When simply running `make' from the selftests top dir, this
error shows up:
cc -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid gpio-mockup-chardev.c ../../../gpio/gpio-utils.o -lmount -o gpio-mockup-chardev
cc: error: ../../../gpio/gpio-utils.o: No such file or directory
<builtin>: recipe for target 'gpio-mockup-chardev' failed
make[1]: *** [gpio-mockup-chardev] Error 1
because the output directory is set to "selftests/gpio" and
all binaries built from ../../../gpio/ end up there. In fact,
they appear as, exempli gratia:
* gpiogpio-event-mon
* gpiogpio-hammer
* gpioinclude/
* gpiolsgpio
which is wrong, as it's missing directory separator somewhere.
This patch sets straight the output directory when building
../../../gpio/ so that binaries don't cross paths.
Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
---
tools/testing/selftests/gpio/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
index 6890f61..46a131a 100644
--- a/tools/testing/selftests/gpio/Makefile
+++ b/tools/testing/selftests/gpio/Makefile
@@ -7,7 +7,7 @@ TEST_PROGS := gpio-mockup.sh
TEST_FILES := gpio-mockup-sysfs.sh
TEST_PROGS_EXTENDED := gpio-mockup-chardev
-GPIODIR := ../../../gpio
+GPIODIR := $(realpath ../../../gpio)
GPIOOBJ := gpio-utils.o
GPIOINC := gpio.h
@@ -15,7 +15,7 @@ all: $(GPIOINC) $(TEST_PROGS_EXTENDED)
override define CLEAN
$(RM) $(TEST_PROGS_EXTENDED)
- $(MAKE) -C $(GPIODIR) clean
+ $(MAKE) -C $(GPIODIR) OUTPUT=$(GPIODIR)/ clean
endef
include ../lib.mk
@@ -23,7 +23,7 @@ include ../lib.mk
$(TEST_PROGS_EXTENDED): $(GPIODIR)/$(GPIOOBJ)
$(GPIODIR)/$(GPIOOBJ):
- $(MAKE) -C $(GPIODIR)
+ $(MAKE) OUTPUT=$(GPIODIR)/ -C $(GPIODIR)
$(GPIOINC):
$(MAKE) -C ../../../.. headers_install
--
2.7.4
next prev parent reply other threads:[~2018-02-21 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 21:52 [PATCH 1/2] selftests: gpio: restructure Makefile Daniel Díaz
2018-02-21 21:52 ` Daniel Díaz [this message]
2018-02-21 22:09 ` [PATCH 2/2] selftests/gpio: Fix OUTPUT directory in Makefile Andy Shevchenko
2018-02-21 23:04 ` Daniel Díaz
2018-02-21 23:11 ` Shuah Khan
2018-02-21 22:06 ` [PATCH 1/2] selftests: gpio: restructure Makefile Andy Shevchenko
2018-02-21 22:45 ` Daniel Díaz
2018-02-21 23:22 ` [PATCH v2] " Daniel Díaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519249964-1630-2-git-send-email-daniel.diaz@linaro.org \
--to=daniel.diaz@linaro.org \
--cc=bamvor.zhangjian@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®