From: "Daniel Díaz" <daniel.diaz@linaro.org>
To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org
Cc: andy.shevchenko@gmail.com,
"Fathi Boudra" <fathi.boudra@linaro.org>,
"Daniel Díaz" <daniel.diaz@linaro.org>,
"Bamvor Jian Zhang" <bamvor.zhangjian@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Shuah Khan" <shuah@kernel.org>,
linux-gpio@vger.kernel.org (open list:GPIO MOCKUP DRIVER),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2] selftests: gpio: restructure Makefile
Date: Wed, 21 Feb 2018 17:22:52 -0600 [thread overview]
Message-ID: <1519255373-10071-1-git-send-email-daniel.diaz@linaro.org> (raw)
In-Reply-To: <1519249964-1630-1-git-send-email-daniel.diaz@linaro.org>
From: Fathi Boudra <fathi.boudra@linaro.org>
This patch cleans up the Makefile by restructuring a couple of
things, namely:
1) change explicit paths in targets for variables
2) substitute a variable (BINARIES) for another, part of the
selftests build system (TEST_PROGS_EXTENDED)
3) proper cleaning up of the EXTRA objects
The resulting Makefile is much more readable and manageable.
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
---
v2: Add commit description
tools/testing/selftests/gpio/Makefile | 36 +++++++++++++++++------------------
1 file changed, 17 insertions(+), 19 deletions(-)
diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
index 1bbb475..6890f61 100644
--- a/tools/testing/selftests/gpio/Makefile
+++ b/tools/testing/selftests/gpio/Makefile
@@ -1,31 +1,29 @@
# SPDX-License-Identifier: GPL-2.0
+CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/
+LDLIBS += -lmount -I/usr/include/libmount
+
TEST_PROGS := gpio-mockup.sh
-TEST_FILES := gpio-mockup-sysfs.sh $(BINARIES)
-BINARIES := gpio-mockup-chardev
-EXTRA_PROGS := ../gpiogpio-event-mon ../gpiogpio-hammer ../gpiolsgpio
-EXTRA_DIRS := ../gpioinclude/
-EXTRA_OBJS := ../gpiogpio-event-mon-in.o ../gpiogpio-event-mon.o
-EXTRA_OBJS += ../gpiogpio-hammer-in.o ../gpiogpio-utils.o ../gpiolsgpio-in.o
-EXTRA_OBJS += ../gpiolsgpio.o
+TEST_FILES := gpio-mockup-sysfs.sh
+TEST_PROGS_EXTENDED := gpio-mockup-chardev
-include ../lib.mk
+GPIODIR := ../../../gpio
+GPIOOBJ := gpio-utils.o
+GPIOINC := gpio.h
-all: $(BINARIES)
+all: $(GPIOINC) $(TEST_PROGS_EXTENDED)
override define CLEAN
- $(RM) $(BINARIES) $(EXTRA_PROGS) $(EXTRA_OBJS)
- $(RM) -r $(EXTRA_DIRS)
+ $(RM) $(TEST_PROGS_EXTENDED)
+ $(MAKE) -C $(GPIODIR) clean
endef
-CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/
-LDLIBS += -lmount -I/usr/include/libmount
-
-$(BINARIES): ../../../gpio/gpio-utils.o ../../../../usr/include/linux/gpio.h
+include ../lib.mk
-../../../gpio/gpio-utils.o:
- make ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C ../../../gpio
+$(TEST_PROGS_EXTENDED): $(GPIODIR)/$(GPIOOBJ)
-../../../../usr/include/linux/gpio.h:
- make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/
+$(GPIODIR)/$(GPIOOBJ):
+ $(MAKE) -C $(GPIODIR)
+$(GPIOINC):
+ $(MAKE) -C ../../../.. headers_install
--
2.7.4
prev parent reply other threads:[~2018-02-21 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 21:52 [PATCH 1/2] " Daniel Díaz
2018-02-21 21:52 ` [PATCH 2/2] selftests/gpio: Fix OUTPUT directory in Makefile Daniel Díaz
2018-02-21 22:09 ` Andy Shevchenko
2018-02-21 23:04 ` Daniel Díaz
2018-02-21 23:11 ` Shuah Khan
2018-02-21 22:06 ` [PATCH 1/2] selftests: gpio: restructure Makefile Andy Shevchenko
2018-02-21 22:45 ` Daniel Díaz
2018-02-21 23:22 ` Daniel Díaz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519255373-10071-1-git-send-email-daniel.diaz@linaro.org \
--to=daniel.diaz@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=bamvor.zhangjian@linaro.org \
--cc=brgl@bgdev.pl \
--cc=fathi.boudra@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®