mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ashok Raj <ashok.raj@intel.com>
To: bp@suse.de
Cc: Ashok Raj <ashok.raj@intel.com>, X86 ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Tony Luck <tony.luck@intel.com>,
	Andi Kleen <andi.kleen@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Arjan Van De Ven <arjan.van.de.ven@intel.com>
Subject: [v2 2/3] x86/microcode/intel: Perform a cache flush before ucode update.
Date: Wed, 21 Feb 2018 22:33:24 -0800	[thread overview]
Message-ID: <1519281205-58951-3-git-send-email-ashok.raj@intel.com> (raw)
In-Reply-To: <1519281205-58951-1-git-send-email-ashok.raj@intel.com>

Microcode updates can be safer if the caches are clean.
Some of the issues around in certain Broadwell parts
can be addressed by doing a full cache flush.

Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Cc: X86 ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Andi Kleen <andi.kleen@intel.com>
Cc: Boris Petkov <bp@suse.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Arjan Van De Ven <arjan.van.de.ven@intel.com>
---
 arch/x86/kernel/cpu/microcode/intel.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index 137c9f5..50e48c4 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -601,6 +601,13 @@ static int apply_microcode_early(struct ucode_cpu_info *uci, bool early)
 		return UCODE_OK;
 	}
 
+	/*
+	 * Microcode updates can be safer if the caches are clean.
+	 * Some of the issues around in certain Broadwell parts
+	 * can be addressed by doing a full cache flush.
+	 */
+	native_wbinvd();
+
 	/* write microcode via MSR 0x79 */
 	native_wrmsrl(MSR_IA32_UCODE_WRITE, (unsigned long)mc->bits);
 
@@ -817,6 +824,13 @@ static enum ucode_state apply_microcode_intel(int cpu)
 		return UCODE_OK;
 	}
 
+	/*
+	 * Microcode updates can be safer if the caches are clean.
+	 * Some of the issues around in certain Broadwell parts
+	 * can be addressed by doing a full cache flush.
+	 */
+	wbinvd();
+
 	/* write microcode via MSR 0x79 */
 	wrmsrl(MSR_IA32_UCODE_WRITE, (unsigned long)mc->bits);
 
-- 
2.7.4

  parent reply	other threads:[~2018-02-22  6:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22  6:33 [v2 0/3] Patches to address some limitations in OS microcode loading Ashok Raj
2018-02-22  6:33 ` [v2 1/3] x86/microcode/intel: Check microcode revision before updating sibling threads Ashok Raj
2018-02-22 11:00   ` Borislav Petkov
2018-02-22 11:55     ` Raj, Ashok
2018-02-22 12:15       ` Borislav Petkov
2018-02-22 13:19         ` Raj, Ashok
2018-02-22 13:44           ` Borislav Petkov
2018-02-22 15:46           ` Henrique de Moraes Holschuh
2018-02-22 15:49             ` Van De Ven, Arjan
2018-02-22 17:51               ` Henrique de Moraes Holschuh
2018-02-22  6:33 ` Ashok Raj [this message]
2018-02-22  6:33 ` [v2 3/3] x86/microcode: Quiesce all threads before a microcode update Ashok Raj
2018-02-22 11:44   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519281205-58951-3-git-send-email-ashok.raj@intel.com \
    --to=ashok.raj@intel.com \
    --cc=andi.kleen@intel.com \
    --cc=arjan.van.de.ven@intel.com \
    --cc=bp@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®