mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
Date: Tue, 27 Feb 2018 05:12:36 +0000	[thread overview]
Message-ID: <1519708355.3120.9.camel@wdc.com> (raw)
In-Reply-To: <db9c47e6-d8ea-1e9e-609a-ff1b1db3769c@oracle.com>

On Tue, 2018-02-27 at 12:00 +0800, jianchao.wang wrote:
> On the other hand, this patch is to align the actions between blk-mq and block
> legacy code in __scsi_queue_insert.

Hello Jianchao,

Since the legacy SCSI core unpreps an reprepares a request when requeuing it I
think your patch does not align the blk-mq and legacy block layer actions but
instead makes the behavior of the two code paths different.

Thanks,

Bart.

  reply	other threads:[~2018-02-27  5:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26  7:58 Jianchao Wang
2018-02-27  3:08 ` Bart Van Assche
2018-02-27  3:28   ` jianchao.wang
2018-02-27  3:41     ` Bart Van Assche
2018-02-27  4:00       ` jianchao.wang
2018-02-27  5:12         ` Bart Van Assche [this message]
2018-02-27  5:15           ` jianchao.wang
2018-02-27 17:06             ` Bart Van Assche
2018-02-27 17:18               ` Bart Van Assche
2018-02-28  2:25                 ` jianchao.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519708355.3120.9.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=hch@lst.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jianchao.w.wang@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®