From: Li Nan <linan666@huaweicloud.com>
To: yukuai@fnnas.com, Li Nan <linan666@huaweicloud.com>, song@kernel.org
Cc: xni@redhat.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yangerkun@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH v2 03/14] md/raid1: use folio for tmppage
Date: Fri, 6 Feb 2026 17:07:41 +0800 [thread overview]
Message-ID: <151dd7eb-4dd0-9183-41eb-d54dfaea3285@huaweicloud.com> (raw)
In-Reply-To: <44521568-3ac0-4374-9c3b-756b8e18192f@fnnas.com>
在 2026/2/5 15:33, Yu Kuai 写道:
> Hi,
>
> 在 2026/2/5 15:23, Li Nan 写道:
>> Yeah, should we introduce safe_put_folio()? Or just check NULL here.
>
> Yes, and don't copy implementation. Just convert safe_put_page(page) to
> safe_put_folio(page_folio(page)) first.
>
page cannot be NULL in page_folio(), and the code would be:
if (page)
safe_put_folio(page_folio(page))
This also looks odd. Keeping both functions and removing the page one
after the last reference to it in RAID5 is removed seems better. What do
you think?
--
Thanks,
Nan
next prev parent reply other threads:[~2026-02-06 9:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 7:56 [PATCH v2 00/14] folio support for sync I/O in RAID linan666
2026-01-28 7:56 ` [PATCH v2 01/14] md/raid1,raid10: clean up of RESYNC_SECTORS linan666
2026-02-04 16:29 ` Yu Kuai
2026-01-28 7:56 ` [PATCH v2 02/14] md: introduce sync_folio_io for folio support in RAID linan666
2026-02-04 16:38 ` Yu Kuai
2026-01-28 7:56 ` [PATCH v2 03/14] md/raid1: use folio for tmppage linan666
2026-02-04 16:45 ` Yu Kuai
2026-02-05 7:23 ` Li Nan
2026-02-05 7:33 ` Yu Kuai
2026-02-06 9:07 ` Li Nan [this message]
2026-01-28 7:56 ` [PATCH v2 04/14] md/raid10: " linan666
2026-01-28 7:56 ` [PATCH v2 05/14] md/raid1,raid10: use folio for sync path IO linan666
2026-01-28 7:57 ` [PATCH v2 06/14] md: Clean up folio sync support related code linan666
2026-02-04 16:52 ` Yu Kuai
2026-02-05 7:27 ` Li Nan
2026-01-28 7:57 ` [PATCH v2 07/14] md/raid1: clean up useless sync_blocks handling in raid1_sync_request linan666
2026-01-28 7:57 ` [PATCH v2 08/14] md/raid1: fix IO error at logical block size granularity linan666
2026-02-04 16:54 ` Yu Kuai
2026-01-28 7:57 ` [PATCH v2 09/14] md/raid10: " linan666
2026-02-04 16:55 ` Yu Kuai
2026-01-28 7:57 ` [PATCH v2 10/14] md/raid1,raid10: clean up resync_fetch_folio linan666
2026-02-04 16:57 ` Yu Kuai
2026-01-28 7:57 ` [PATCH v2 11/14] md: clean up resync_free_folio linan666
2026-02-04 16:59 ` Yu Kuai
2026-01-28 7:57 ` [PATCH v2 12/14] md/raid1: clean up sync IO size calculation in raid1_sync_request linan666
2026-01-28 7:57 ` [PATCH v2 13/14] md/raid10: clean up sync IO size calculation in raid10_sync_request linan666
2026-01-28 7:57 ` [PATCH v2 14/14] md/raid1,raid10: fall back to smaller order if sync folio alloc fails linan666
2026-02-04 16:48 ` Yu Kuai
2026-02-05 7:29 ` Li Nan
2026-02-04 17:02 ` [PATCH v2 00/14] folio support for sync I/O in RAID Yu Kuai
2026-02-05 12:57 ` Li Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151dd7eb-4dd0-9183-41eb-d54dfaea3285@huaweicloud.com \
--to=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®