mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yu Kuai" <yukuai@fnnas.com>
To: <linan666@huaweicloud.com>, <song@kernel.org>
Cc: <xni@redhat.com>, <linux-raid@vger.kernel.org>,
	 <linux-kernel@vger.kernel.org>, <yangerkun@huawei.com>,
	 <yi.zhang@huawei.com>, <yukuai@fnnas.com>
Subject: Re: [PATCH v2 10/14] md/raid1,raid10: clean up resync_fetch_folio
Date: Thu, 5 Feb 2026 00:57:20 +0800	[thread overview]
Message-ID: <3fe2e132-f5bd-466a-b43b-7a2ac27813d7@fnnas.com> (raw)
In-Reply-To: <20260128075708.2259525-11-linan666@huaweicloud.com>

Hi,

在 2026/1/28 15:57, linan666@huaweicloud.com 写道:
> From: Li Nan <linan122@huawei.com>
>
> The helper resync_fetch_folio() only returns the folio member without
> any additional logic. Clean it up by accessing rf->folio directly.
>
> Signed-off-by: Li Nan <linan122@huawei.com>
> ---
>   drivers/md/raid1-10.c |  7 +------
>   drivers/md/raid1.c    | 10 ++++------
>   drivers/md/raid10.c   |  3 +--
>   3 files changed, 6 insertions(+), 14 deletions(-)

Again, I think this patch should be merged into patch 5.

>
> diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c
> index 568ab002691f..2ff1f8855900 100644
> --- a/drivers/md/raid1-10.c
> +++ b/drivers/md/raid1-10.c
> @@ -55,11 +55,6 @@ static inline void resync_free_folio(struct resync_folio *rf)
>   	folio_put(rf->folio);
>   }
>   
> -static inline struct folio *resync_fetch_folio(struct resync_folio *rf)
> -{
> -	return rf->folio;
> -}
> -
>   /*
>    * 'strct resync_folio' stores actual pages used for doing the resync
>    *  IO, and it is per-bio, so make .bi_private points to it.
> @@ -74,7 +69,7 @@ static void md_bio_reset_resync_folio(struct bio *bio, struct resync_folio *rf,
>   			       int size)
>   {
>   	/* initialize bvec table again */
> -	if (WARN_ON(!bio_add_folio(bio, resync_fetch_folio(rf),
> +	if (WARN_ON(!bio_add_folio(bio, rf->folio,
>   				   min_t(int, size, RESYNC_BLOCK_SIZE),
>   				   0))) {
>   		bio->bi_status = BLK_STS_RESOURCE;
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 27e3b2375b16..a303349eeff4 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -2981,8 +2981,8 @@ static sector_t raid1_sync_request(struct mddev *mddev, sector_t sector_nr,
>   		max_sector = sector_nr + good_sectors;
>   	nr_sectors = 0;
>   	do {
> -		struct folio *folio;
>   		int len = RESYNC_BLOCK_SIZE;
> +
>   		if (sector_nr + (len>>9) > max_sector)
>   			len = (max_sector - sector_nr) << 9;
>   		if (len == 0)
> @@ -2996,13 +2996,11 @@ static sector_t raid1_sync_request(struct mddev *mddev, sector_t sector_nr,
>   			len = sync_blocks<<9;
>   
>   		for (i = 0 ; i < conf->raid_disks * 2; i++) {
> -			struct resync_folio *rf;
> -
>   			bio = r1_bio->bios[i];
> -			rf = get_resync_folio(bio);
>   			if (bio->bi_end_io) {
> -				folio = resync_fetch_folio(rf);
> -				bio_add_folio_nofail(bio, folio, len, 0);
> +				struct resync_folio *rf = get_resync_folio(bio);
> +
> +				bio_add_folio_nofail(bio, rf->folio, len, 0);
>   			}
>   		}
>   		nr_sectors += len>>9;
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 06257eea97ed..d8a5fadfc933 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -3630,9 +3630,8 @@ static sector_t raid10_sync_request(struct mddev *mddev, sector_t sector_nr,
>   			break;
>   		for (bio= biolist ; bio ; bio=bio->bi_next) {
>   			struct resync_folio *rf = get_resync_folio(bio);
> -			struct folio *folio = resync_fetch_folio(rf);
>   
> -			if (WARN_ON(!bio_add_folio(bio, folio, len, 0))) {
> +			if (WARN_ON(!bio_add_folio(bio, rf->folio, len, 0))) {
>   				bio->bi_status = BLK_STS_RESOURCE;
>   				bio_endio(bio);
>   				*skipped = 1;

-- 
Thansk,
Kuai

  reply	other threads:[~2026-02-04 16:57 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  7:56 [PATCH v2 00/14] folio support for sync I/O in RAID linan666
2026-01-28  7:56 ` [PATCH v2 01/14] md/raid1,raid10: clean up of RESYNC_SECTORS linan666
2026-02-04 16:29   ` Yu Kuai
2026-01-28  7:56 ` [PATCH v2 02/14] md: introduce sync_folio_io for folio support in RAID linan666
2026-02-04 16:38   ` Yu Kuai
2026-01-28  7:56 ` [PATCH v2 03/14] md/raid1: use folio for tmppage linan666
2026-02-04 16:45   ` Yu Kuai
2026-02-05  7:23     ` Li Nan
2026-02-05  7:33       ` Yu Kuai
2026-02-06  9:07         ` Li Nan
2026-01-28  7:56 ` [PATCH v2 04/14] md/raid10: " linan666
2026-01-28  7:56 ` [PATCH v2 05/14] md/raid1,raid10: use folio for sync path IO linan666
2026-01-28  7:57 ` [PATCH v2 06/14] md: Clean up folio sync support related code linan666
2026-02-04 16:52   ` Yu Kuai
2026-02-05  7:27     ` Li Nan
2026-01-28  7:57 ` [PATCH v2 07/14] md/raid1: clean up useless sync_blocks handling in raid1_sync_request linan666
2026-01-28  7:57 ` [PATCH v2 08/14] md/raid1: fix IO error at logical block size granularity linan666
2026-02-04 16:54   ` Yu Kuai
2026-01-28  7:57 ` [PATCH v2 09/14] md/raid10: " linan666
2026-02-04 16:55   ` Yu Kuai
2026-01-28  7:57 ` [PATCH v2 10/14] md/raid1,raid10: clean up resync_fetch_folio linan666
2026-02-04 16:57   ` Yu Kuai [this message]
2026-01-28  7:57 ` [PATCH v2 11/14] md: clean up resync_free_folio linan666
2026-02-04 16:59   ` Yu Kuai
2026-01-28  7:57 ` [PATCH v2 12/14] md/raid1: clean up sync IO size calculation in raid1_sync_request linan666
2026-01-28  7:57 ` [PATCH v2 13/14] md/raid10: clean up sync IO size calculation in raid10_sync_request linan666
2026-01-28  7:57 ` [PATCH v2 14/14] md/raid1,raid10: fall back to smaller order if sync folio alloc fails linan666
2026-02-04 16:48   ` Yu Kuai
2026-02-05  7:29     ` Li Nan
2026-02-04 17:02 ` [PATCH v2 00/14] folio support for sync I/O in RAID Yu Kuai
2026-02-05 12:57   ` Li Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fe2e132-f5bd-466a-b43b-7a2ac27813d7@fnnas.com \
    --to=yukuai@fnnas.com \
    --cc=linan666@huaweicloud.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®