From: "Hook, Gary" <ghook@amd.com>
To: "Mehta, Sohil" <sohil.mehta@intel.com>,
"shunyong.yang@hxt-semitech.com" <shunyong.yang@hxt-semitech.com>,
"gary.hook@amd.com" <gary.hook@amd.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
Date: Wed, 18 Apr 2018 16:51:26 -0400 [thread overview]
Message-ID: <151f3396-959b-86f6-e056-58d38682d858@amd.com> (raw)
In-Reply-To: <1524082659.2747.37.camel@intel.com>
On 4/18/2018 4:16 PM, Mehta, Sohil wrote:
> On Wed, 2018-04-18 at 08:31 +0000, Yang, Shunyong wrote:
>> Maybe the original design is to call debugfs_initialized() before
>> calling debugfs_create_xxx()?
>
> I am unaware of the original design. Someone else would probably have
> more context. However, looking at other places in the kernel where
> debugfs_create_xx() is used, the common convention seems to be to avoid
> calling debugfs_initialized().
>
> Sohil
>
debugfs_initialized() was introduced in commit c0f92ba99 back in
2.6.30-rc1. It was intended as a helper, not as a gatekeeper, which is
why one doesn't see it used. Given that my use in this proposed patch is
straightforward, I'm not seeing the need here. I had just seen some
other code that used it, and copied the model.
Unless someone comes along to say, yes, use it, I'll not.
Gary
next prev parent reply other threads:[~2018-04-18 20:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 13:17 [PATCH v3 0/2] Base enablement of IOMMU debugfs support Gary R Hook
2018-04-06 13:17 ` [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU Gary R Hook
2018-04-13 23:55 ` Mehta, Sohil
2018-04-17 17:36 ` Hook, Gary
2018-04-17 17:55 ` Robin Murphy
2018-04-17 18:06 ` Hook, Gary
2018-04-17 17:46 ` Hook, Gary
2018-04-17 18:13 ` Robin Murphy
2018-04-06 13:17 ` [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Gary R Hook
2018-04-14 0:08 ` Mehta, Sohil
2018-04-17 17:38 ` Hook, Gary
2018-04-18 5:58 ` Yang, Shunyong
2018-04-18 7:27 ` Mehta, Sohil
2018-04-18 8:31 ` Yang, Shunyong
2018-04-18 20:16 ` Mehta, Sohil
2018-04-18 20:51 ` Hook, Gary [this message]
2018-04-19 1:52 ` Yang, Shunyong
2018-04-30 19:57 ` Gary R Hook
2018-04-17 0:52 ` Mehta, Sohil
2018-04-17 17:42 ` Hook, Gary
2018-04-17 18:05 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151f3396-959b-86f6-e056-58d38682d858@amd.com \
--to=ghook@amd.com \
--cc=gary.hook@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shunyong.yang@hxt-semitech.com \
--cc=sohil.mehta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome