From: Arnd Bergmann <arnd@arndb.de>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
Marcin Wojtas <mw@semihalf.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: sram: remove useless #ifdef
Date: Wed, 30 Nov 2016 15:44:55 +0100 [thread overview]
Message-ID: <15207778.B3o1gTucM7@wuerfel> (raw)
In-Reply-To: <63d62ef3-66dc-bca5-fb12-a14dd1ad324d@mleia.com>
On Tuesday, November 22, 2016 7:47:52 PM CET Vladimir Zapolskiy wrote:
>
> On 11/22/2016 04:30 PM, Arnd Bergmann wrote:
> > A recent patch added a new function that is now unused whenever
> > CONFIG_OF is disabled:
> >
> > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function]
> >
> > There is actually no reason for the #ifdef, because the driver
> > currently cannot be used in a meaningful way without CONFIG_OF,
> > and there is no compile-time dependency.
> >
> > Removing that #ifdef and the respective of_match_ptr() avoids the
> > warning and simplifies the driver slightly.
> >
> > Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support")
>
> I can not find the referenced commit on Torvald's branch,
> won't it be rebased and get a changed commit hash after merge?
>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
>
> The change itself is good, thank you for the fix.
>
> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
>
Applied on arm-soc/next/drivers now, thanks.
Arnd
next prev parent reply other threads:[~2016-11-30 14:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 14:30 Arnd Bergmann
2016-11-22 17:47 ` Vladimir Zapolskiy
2016-11-22 17:59 ` Alexandre Belloni
2016-11-30 14:44 ` Arnd Bergmann [this message]
2016-11-29 19:41 ` Greg Kroah-Hartman
2016-11-29 19:54 ` Alexandre Belloni
2016-11-29 20:01 ` Greg Kroah-Hartman
2016-11-29 23:30 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15207778.B3o1gTucM7@wuerfel \
--to=arnd@arndb.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®