* [PATCH] drm/imx: Remove last traces of struct imx_drm_crtc
@ 2018-03-27 21:39 Leonard Crestez
2018-04-03 23:56 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Leonard Crestez @ 2018-03-27 21:39 UTC (permalink / raw)
To: Philipp Zabel, Shawn Guo; +Cc: David Airlie, Liu Ying, dri-devel, linux-kernel
When the definition of this struct was removed a forward declaration and an
unused struct member were still left around. Remove them because they serve
no purpose.
Fixes 44b460cfe554 ("drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs")
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
drivers/gpu/drm/imx/imx-drm.h | 1 -
drivers/gpu/drm/imx/ipuv3-crtc.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm.h b/drivers/gpu/drm/imx/imx-drm.h
index 15c2bec..ab9c6f7 100644
--- a/drivers/gpu/drm/imx/imx-drm.h
+++ b/drivers/gpu/drm/imx/imx-drm.h
@@ -10,7 +10,6 @@ struct drm_display_mode;
struct drm_encoder;
struct drm_framebuffer;
struct drm_plane;
-struct imx_drm_crtc;
struct platform_device;
struct imx_crtc_state {
diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c
index e83af0f..50d9f2bb 100644
--- a/drivers/gpu/drm/imx/ipuv3-crtc.c
+++ b/drivers/gpu/drm/imx/ipuv3-crtc.c
@@ -35,7 +35,6 @@
struct ipu_crtc {
struct device *dev;
struct drm_crtc base;
- struct imx_drm_crtc *imx_crtc;
/* plane[0] is the full plane, plane[1] is the partial plane */
struct ipu_plane *plane[2];
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/imx: Remove last traces of struct imx_drm_crtc
2018-03-27 21:39 [PATCH] drm/imx: Remove last traces of struct imx_drm_crtc Leonard Crestez
@ 2018-04-03 23:56 ` Fabio Estevam
2018-04-04 8:29 ` Philipp Zabel
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2018-04-03 23:56 UTC (permalink / raw)
To: Leonard Crestez
Cc: Philipp Zabel, Shawn Guo, David Airlie, DRI mailing list, linux-kernel
On Tue, Mar 27, 2018 at 6:39 PM, Leonard Crestez
<leonard.crestez@nxp.com> wrote:
> When the definition of this struct was removed a forward declaration and an
> unused struct member were still left around. Remove them because they serve
> no purpose.
>
> Fixes 44b460cfe554 ("drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs")
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/imx: Remove last traces of struct imx_drm_crtc
2018-04-03 23:56 ` Fabio Estevam
@ 2018-04-04 8:29 ` Philipp Zabel
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2018-04-04 8:29 UTC (permalink / raw)
To: Fabio Estevam, Leonard Crestez
Cc: Shawn Guo, David Airlie, DRI mailing list, linux-kernel
On Tue, 2018-04-03 at 20:56 -0300, Fabio Estevam wrote:
> On Tue, Mar 27, 2018 at 6:39 PM, Leonard Crestez
> <leonard.crestez@nxp.com> wrote:
> > When the definition of this struct was removed a forward declaration and an
> > unused struct member were still left around. Remove them because they serve
> > no purpose.
> >
> > Fixes 44b460cfe554 ("drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs")
> >
> > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Thank you, applied to imx-drm/next.
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-04 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-27 21:39 [PATCH] drm/imx: Remove last traces of struct imx_drm_crtc Leonard Crestez
2018-04-03 23:56 ` Fabio Estevam
2018-04-04 8:29 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®