From: David Howells <dhowells@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: dhowells@redhat.com, "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net] rxrpc: fix uninitialized pointer dereference in debug code
Date: Mon, 08 Aug 2016 13:48:24 +0100 [thread overview]
Message-ID: <1525.1470660504@warthog.procyon.org.uk> (raw)
In-Reply-To: <20160808101357.1583011-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> wrote:
> A newly added bugfix caused an uninitialized variable to be
> used for printing debug output. This is harmless as long
> as the debug setting is disabled, but otherwise leads to an
> immediate crash.
>
> gcc warns about this when -Wmaybe-uninitialized is enabled:
>
> net/rxrpc/call_object.c: In function 'rxrpc_release_call':
> net/rxrpc/call_object.c:496:163: error: 'sp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> The initialization was removed but one of the users remains.
> This adds back the initialization.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 372ee16386bb ("rxrpc: Fix races between skb free, ACK generation and replying")
Applied, thanks.
David
prev parent reply other threads:[~2016-08-08 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 10:13 Arnd Bergmann
2016-08-08 12:48 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525.1470660504@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®