* [PATCH] fs/coda: add error handling for fget
@ 2018-06-12 4:34 Zhouyang Jia
0 siblings, 0 replies; only message in thread
From: Zhouyang Jia @ 2018-06-12 4:34 UTC (permalink / raw)
Cc: Zhouyang Jia, Jan Harkes, coda, codalist, linux-kernel
When fget fails, the lack of error-handling code may
cause unexpected results.
This patch adds error-handling code after calling fget.
Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
---
fs/coda/psdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c
index c5234c2..55824cb 100644
--- a/fs/coda/psdev.c
+++ b/fs/coda/psdev.c
@@ -187,8 +187,11 @@ static ssize_t coda_psdev_write(struct file *file, const char __user *buf,
if (req->uc_opcode == CODA_OPEN_BY_FD) {
struct coda_open_by_fd_out *outp =
(struct coda_open_by_fd_out *)req->uc_data;
- if (!outp->oh.result)
+ if (!outp->oh.result) {
outp->fh = fget(outp->fd);
+ if (!outp->fh)
+ return -EBADF;
+ }
}
wake_up(&req->uc_sleep);
--
2.7.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-06-12 4:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 4:34 [PATCH] fs/coda: add error handling for fget Zhouyang Jia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®