* [PATCH] fsi: sbefifo: Add missing mutex_unlock
@ 2018-07-03 21:21 Eddie James
2018-07-04 1:11 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Eddie James @ 2018-07-03 21:21 UTC (permalink / raw)
To: linux-kernel; +Cc: openbmc, joel, benh, Eddie James
There was no unlock of the FFDC mutex.
Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com>
---
drivers/fsi/fsi-sbefifo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index 4f076fd..a34ff99 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -194,6 +194,7 @@ static void sbefifo_dump_ffdc(struct device *dev, const __be32 *ffdc,
}
dev_warn(dev, "+-------------------------------------------+\n");
}
+ mutex_unlock(&sbefifo_ffdc_mutex);
}
int sbefifo_parse_status(struct device *dev, u16 cmd, __be32 *response,
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fsi: sbefifo: Add missing mutex_unlock
2018-07-03 21:21 [PATCH] fsi: sbefifo: Add missing mutex_unlock Eddie James
@ 2018-07-04 1:11 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2018-07-04 1:11 UTC (permalink / raw)
To: Eddie James, linux-kernel; +Cc: openbmc, joel
On Tue, 2018-07-03 at 16:21 -0500, Eddie James wrote:
> There was no unlock of the FFDC mutex.
>
> Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
> Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com>
Thanks.
Cheers,
Ben.
> ---
> drivers/fsi/fsi-sbefifo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 4f076fd..a34ff99 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -194,6 +194,7 @@ static void sbefifo_dump_ffdc(struct device *dev, const __be32 *ffdc,
> }
> dev_warn(dev, "+-------------------------------------------+\n");
> }
> + mutex_unlock(&sbefifo_ffdc_mutex);
> }
>
> int sbefifo_parse_status(struct device *dev, u16 cmd, __be32 *response,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-04 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-03 21:21 [PATCH] fsi: sbefifo: Add missing mutex_unlock Eddie James
2018-07-04 1:11 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome